Skip to content

reiserfs cleanup patchset

Jeff Mahoney reiserfs-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest28 of 29 patches 21 repliesIn review

28 of 29 patches are in this archive. The cover letter announces 29.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/29reiserfs: use per-fs commit workqueuesfs/reiserfs/journal.c fs/reiserfs/reiserfs.h fs/reiserfs/super.c+20 -250 replies
2/29reiserfs: cleanup, rename key and item accessors to more friendly namesfs/reiserfs/bitmap.c fs/reiserfs/dir.c fs/reiserfs/do_balan.c +11 more+284 -2390 replies
4/29reiserfs: cleanup, remove nblocks argument from journal_endfs/reiserfs/file.c fs/reiserfs/inode.c fs/reiserfs/journal.c +7 more+75 -900 replies
5/29reiserfs: cleanup, remove sb argument from journal_endfs/reiserfs/file.c fs/reiserfs/inode.c fs/reiserfs/journal.c +7 more+79 -790 replies
6/29reiserfs: cleanup, remove sb argument from journal_mark_dirtyfs/reiserfs/bitmap.c fs/reiserfs/do_balan.c fs/reiserfs/file.c +9 more+35 -380 replies
7/29reiserfs: cleanup, remove blocks arg from journal_joinfs/reiserfs/file.c fs/reiserfs/journal.c fs/reiserfs/reiserfs.h+11 -110 replies
8/29reiserfs: cleanup, remove leading whitespace from labelsfs/reiserfs/bitmap.c fs/reiserfs/dir.c fs/reiserfs/file.c +8 more+68 -680 replies
9/29reiserfs: cleanup, remove unnecessary parensfs/reiserfs/bitmap.c fs/reiserfs/dir.c fs/reiserfs/do_balan.c +12 more+129 -1300 replies
10/29reiserfs: cleanup, remove unnecessary parens in dirent creationfs/reiserfs/dir.c+34 -330 replies
11/29reiserfs: cleanup, make hash detection sanerfs/reiserfs/super.c+50 -583 replies
12/29reiserfs: balance_leaf refactor, reformat balance_leaf commentsfs/reiserfs/do_balan.c+52 -320 replies
13/29reiserfs: balance_leaf refactor, move state variables into tree_balancefs/reiserfs/do_balan.c fs/reiserfs/fix_node.c fs/reiserfs/prints.c +1 more+214 -2220 replies
14/29reiserfs: balance_leaf refactor, pull out balance_leaf_insert_leftfs/reiserfs/do_balan.c+59 -490 replies
15/29reiserfs: balance_leaf refactor, pull out balance_leaf_paste_leftfs/reiserfs/do_balan.c+64 -530 replies
16/29reiserfs: balance_leaf refactor, pull out balance_leaf_insert_rightfs/reiserfs/do_balan.c+75 -630 replies
17/29reiserfs: balance_leaf refactor, pull out balance_leaf_paste_rightfs/reiserfs/do_balan.c+90 -800 replies
18/29reiserfs: balance_leaf refactor, pull out balance_leaf_new_nodes_insertfs/reiserfs/do_balan.c+73 -600 replies
19/29reiserfs: balance_leaf refactor, pull out balance_leaf_new_nodes_pastefs/reiserfs/do_balan.c+160 -1460 replies
20/29reiserfs: balance_leaf refactor pull out balance_leaf_finish_node_insertfs/reiserfs/do_balan.c+21 -90 replies
21/29reiserfs: balance_leaf refactor, pull out balance_leaf_finish_node_pastefs/reiserfs/do_balan.c+79 -710 replies
22/29reiserfs: balance_leaf refactor, pull out balance_leaf{left, right, new_nodes, finish_node}fs/reiserfs/do_balan.c+108 -990 replies
23/29reiserfs: balance_leaf refactor, format balance_leaf_insert_leftfs/reiserfs/do_balan.c+57 -500 replies
24/29reiserfs: balance_leaf refactor, format balance_leaf_paste_leftfs/reiserfs/do_balan.c+235 -1520 replies
25/29reiserfs: balance_leaf refactor, format balance_leaf_insert_rightfs/reiserfs/do_balan.c+76 -630 replies
26/29reiserfs: balance_leaf refactor, format balance_leaf_paste_rightfs/reiserfs/do_balan.c+170 -1300 replies
27/29reiserfs: balance_leaf refactor, format balance_leaf_new_nodes_pastefs/reiserfs/do_balan.c+282 -2160 replies
28/29reiserfs: balance_leaf refactor, format balance_leaf_finish_nodefs/reiserfs/do_balan.c+72 -910 replies
29/29reiserfs: balance_leaf refactor, split up balance_leaf_when_deletefs/reiserfs/do_balan.c+163 -1550 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 00/29] reiserfs cleanup patchset

Hi all -

I've had this patchset kicking around for a while. After a conversation this past week about code that was horrible to read (using reiserfs's balance_leaf as the primary example) and seeing that Dave Jones had scratched a bit of an itch, I decided it was time to resync and push it out so I don't have to update it forever.

BTW, as I'm basically the only person with substantial patches against reiserfs, I'm 100% ok with disrupting context to this extent. :)

This set consists of 29 patches in a few areas.

1 - Convert the commit workqueue to a per-fs workqueue
2 - Clean up ugly accessor macros to use more readable names
3 - Clean up comments to use the normal kernel style
4 - Remove the unused nblocks argument from journal_end
5 - Remove superblock argument from journal_end (it's in the trans handle) 6 - Remove superblock argument from journal_mark_dirty (see #5) 7 - Remove blocks argument from journal_join (it's always 1)
8 - Remove leading whitespace from labels
9 - Remove unnecessary parents
10 - Clean up dirent creation
11 - Clean up hash detection
12-29 - Clean up balance_leaf - This 2500-line function goes through
6 easily distinguishable stages, each with several sub-parts. The patch set splits up the stages and then reformats them to keep the split as obvious as possible. The final result is a whole lot easier to follow and easier on the eyes.

-Jeff