Skip to content

uprobes/tracing: uprobe_perf_open()->uprobe_apply() fix

Oleg Nesterov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 1 replyIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2uprobes/tracing: Make uprobe_perf_close() visible to uprobe_perf_open()kernel/trace/trace_uprobe.c+18 -180 replies
2/2uprobes/tracing: Fix uprobe_perf_open() on uprobe_apply() failurekernel/trace/trace_uprobe.c+9 -50 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSteven RostedtSrikar Dronamraju
1/2A-b A-b
2/2A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] uprobes/tracing: uprobe_perf_open()->uprobe_apply() fix
Quoted 6 lines · Steven Rostedt

Egad, this confused the heck out of me. I didn't notice the swap in functions and was wondering what you were doing. I didn't realize this is what you meant by moving the uprobe_perf_close() up. I was thinking you moved the call up or something, not the function itself physically in the file.

...

Quoted 3 lines

You can add by Acked-by, but next time, please make this into two patches. One to do the move, the other to do the change.

OK...

I tried to lessen the number of patches I have ;) But I agree, this simple fix looks too complicated without preparation which only moves the code.

Let me split it then. Result is the same do I preserved the acks, this is what I am going to add to my tree.

Thanks!

Oleg.