uprobes/x86: cleanup "riprel" functions
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | uprobes/x86: Rename *riprel* helpers to make the naming consistentarch/ | +11 | 2 replies | |
| 2/3 | uprobes/x86: Kill the "autask" arg of riprel_pre_xol()arch/ | +9 | 2 replies | |
| 3/3 | uprobes/x86: Simplify riprel_{pre,post}_xol() and make them similararch/ | +14 | 2 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Srikar Dronamraju | Jim Keniston |
|---|---|---|
| 1/3 | A-b | R-b |
| 2/3 | A-b | R-b |
| 3/3 | A-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] uprobes/x86: cleanup "riprel" functions
Quoted 9 lines · Oleg Nesterov
Quoted 3 lines · Oleg Nesterov
This series only fixes the problem. I'll send more changes to address some of TODO's mentioned in the changelogs later.
This is probably the last series I am sending in this thread, before the next PULL request. This completes the changes which I planned from the very beginning, except "emulate jczx/loopz" which I am still unsure about.
I lied, let me send another short series.
I was not going to do this now, I am a bit tired of uprobes ;) But it seems that Denys has a very good idea, we can simplify rip-relative handling.
However, if we are are going to change this code, imho we need to cleanup it first. handle_riprel_insn(), pre_xol_rip_insn() and handle_riprel_post_xol() look really annoying, imho. Even the naming asks for the cleanup imo, despite the fact that usually I ignore the naming completely.
Oleg.
arch/x86/kernel/uprobes.c | 56 +++++++++++++++++++++------------------------ 1 files changed, 26 insertions(+), 30 deletions(-)