dma: edma: Provide granular residue accounting
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest posting 2/20 of 6 patches 0 repliesNew
- v2 posting 1/20 of 6 patches 0 repliesSuperseded
Patches in v2 posting 2/2 No applies recorded yet
None of the 6 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [patch V2 0/6] dma: edma: Provide granular residue accounting
Quoted 30 lines · Joel Fernandes
On 04/29/2014 03:46 AM, Vinod Koul wrote:
[..]Quoted 28 lines
commit
770f0f3a20188b7e17db2790803b9da925dc0b94Author: Thomas Gleixner <[email protected]> Date: Mon Apr 28 10:49:43 2014 +0000dmaengine: edma: Make reading the position of active channels work
As Joel pointed out,
edma_read_position()usesmemcpy_fromio()to read the parameter ram. That's not synchronized with the internal update as it does a byte by byte copy. We need to do a 32bit read to get a consistent value.Further reading destination and source is pointless. In
DEV_TO_MEMtransfers we are only interested in the destination, inMEM_TO_DEVwe care about the source. InMEM_TO_MEMit really does not matter which one you read.Simple solution: Remove the pointers, select dest/source via a bool and return the read value.
Remove the export of this function while at it. The only potential user is the dmaengine and that's always builtin.
Signed-off-by Thomas Gleixner <[email protected]>You s-o-b missing in this one, also ack from Sekhar missing. Do you want to redo this or prefer me to cherry-pick patches adding acks and your s-o-b, since I already fetched your branch
Quoted 5 lines
Quoted 2 lines
Either way is fine with me...
If its Ok with you, it would great if you could add my Ack and Sob. Thanks a lot. Let me know if you'd want me to do anything else here.
Done, The changes are getting pushed, pls do verify
Signature · 1 line
~Vinod