Skip to content

staging/skein: more cleanup

Jake Edge lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging/skein: move all threefish block functions to one filedrivers/staging/skein/Makefile drivers/staging/skein/threefish_1024_block.c drivers/staging/skein/threefish_256_block.c +2 more+8259 -82690 replies
2/3staging/skein: comment typosdrivers/staging/skein/threefish_api.h+9 -90 replies
3/3staging/skein: variable/member name cleanupdrivers/staging/skein/skein.c drivers/staging/skein/skein.h drivers/staging/skein/skein_api.c +2 more+186 -1850 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJason Cooper
SeriesA-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] staging/skein: more cleanup

Clean up a few more things in skein to get it closer to mainline inclusion. The first may be questionable (so I probably should have put it last -- oh well, I can always respin), but it seemed like putting all of the threefish block functions in one file, like the skein block functions are all in one file, made sense.

Jake Edge (3):
move all threefish block functions to one file, remove unneeded
include
fix some comment typos
Rename a few more variables and structure member names to lower case.

 drivers/staging/skein/Makefile               |    4 +-
 drivers/staging/skein/skein.c                |  148 +-
 drivers/staging/skein/skein.h                |   34 +-
 drivers/staging/skein/skein_api.c            |   32 +-
 drivers/staging/skein/skein_api.h            |    2 +-
 drivers/staging/skein/skein_block.c          |  155 +-
 drivers/staging/skein/threefish_1024_block.c | 4902 ---------------
 drivers/staging/skein/threefish_256_block.c  | 1139 ----
 drivers/staging/skein/threefish_512_block.c  | 2225 -------
 drivers/staging/skein/threefish_api.h        |   18 +-
 drivers/staging/skein/threefish_block.c      | 8258 ++++++++++++++++++++++++++
 11 files changed, 8454 insertions(+), 8463 deletions(-)
 delete mode 100644 drivers/staging/skein/threefish_1024_block.c
 delete mode 100644 drivers/staging/skein/threefish_256_block.c
 delete mode 100644 drivers/staging/skein/threefish_512_block.c
 create mode 100644 drivers/staging/skein/threefish_block.c
Signature · 1 line
1.9.0