Some download-related changes (branch yem/check-downloads)
Get series with b4
b4 am [email protected]Versions newest first
- v5 Latest0 of 11 patches 0 repliesNew
Patches in v5 No applies recorded yet
None of the 11 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.
Cover letter [Buildroot] [PATCH 0/11 v5] Some download-related changes (branch yem/check-downloads)
Dear Yann E. MORIN,
Quoted 2 lines · Yann E. MORIN
Well, that's basically what happens in patch 8/11 (as you noticed already!).
Yes, right!
Quoted 13 lines
You said on IRC:
at least for the wget download method, it's still wrong.What Arnout said is that we want to create the temporary file in the same filesystem as for the final file.
That can only be true if we create the temp file in the same directory as the final file, as we have no info about the mountpoints.
But, as you said you want it to work even for parallel downloads, we will have to do a bit of a gymnastic to avoid to builds in different directories clobbering each others temp files.
Quoted 5 lines
So, of course, two parallel wget will step on each other's temp file. Ditto for the other downloaders.
So, we must create temp files and temp clones with unique names. I'll use mktemp for that.
Ah, yes, indeed, makes sense. It will work even if $(O) and $(DL_DIR) are in separate file systems *and* provide the atomicity guarantees that we need to use the same $(DL_DIR) for several parallel builds.
Looks good. I guess you'll respin the series with this change?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com