Skip to content

arm:dma-mapping Refactoring iommu dma-mapping code

Will Deacon linux-arm-kernel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] arm:dma-mapping Refactoring iommu dma-mapping code
Quoted 2 lines · ritesh.harjani at gmail.com

From: Ritesh Harjani <[email protected]>
Hi All,

Hi Ritesh,

Thanks for the new patches. I have a few comments on the series as a whole.

Quoted 8 lines

This patch series is to refractor iommu related common code from arch/arm/dma-mapping.c to lib/iommu-helper.c based on the various discussions with the maintainers/experts [1].

Currently the only user of the common lib/iommu-helper code will be ARM & ARM64 but later various architecture might try to use this iommu lib helper functions.

Quoted 5 lines

Major change of this refactoring starts with bringing out struct dma_iommu_mapping *mapping variable from arch/arm/include/asm/device.h to include/linux/device.h and by moving out complete structure defination of dma_iommu_mapping to inclue/linux/iommu-helper.h. Link [2] give more details on why this was done, also this change got approval from Will Daecon [2].

Well, I can't approve changes to include/linux/device.h, so that probably needs to be acked by Grant and/or Greg. Could you split that patch out into a separate change please, so that it can go in independently?

Also, I think you could merge patches 2 and 3, no?

Quoted 3 lines

There are 1/2 more function definitions which I can think of moving out, but those can be done once this patch series is approved as those are not very big changes.

This certainly looks good to start with, although I think you should consider renaming the functions in the helper library so that they aren't prefixed with double underscores. Maybe iommu_helper_* instead?

Finally, please drop the ChangeId entries from your commit messages (and you've consistently misspelled refactor as refractor).

Will

Read the cover letter in its thread