ARM: shmobile: Rework include path (Try 2, Part 1)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 8 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 8 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/08] ARM: shmobile: Rework include path (Try 2, Part 1)
Quoted 16 lines · Geert Uytterhoeven
Hi Magnus,
Quoted 13 lines · Magnus Damm
ARM: shmobile: Rework include path (Try 2, Part 1)
[PATCH 01/08] ARM: shmobile: Move
intc.h, cleanupsh_intc.husage [PATCH 02/08] ARM: shmobile: Movedma-register.h
[PATCH 03/08] ARM: shmobile: Moveclock.h
[PATCH 04/08] ARM: shmobile: Move most ofirqs.h, keep some for pinctl [PATCH 05/08] ARM: shmobile: Movecommon.h
[PATCH 06/08] ARM: shmobile: Movepm-rmobile.h, cleanupsh73xx.h[PATCH 07/08] ARM: shmobile: Movepm-rcar.h, cleanup r8a7779 case [PATCH 08/08] ARM: shmobile: Movercar-gen2.h, cleanup r8a7790 caseOlof, here my latest take on the header move that you requested earlier.
Quoted 7 lines
Quoted 4 lines
This particular series hopefully follows your proposed way and moves the most common shared header files for mach-shmobile from <
mach/foobar.h> to "foobar.h" without any workaround. Left are still per-SoC header files that will be moved once I know you are comformatble with this format.Olof didn't scream, so I guess he's comfortable with it? :-) Olof?
I'd value a nod or otherwise from Olof before merging this.
Quoted 2 lines
If the propagation part is an issue, what about Simon applying it to a separate branch, to be merged into both soc-for-v3.17 and boards-for-v3.17?
Yes, I think this will need to go into a cleanup branch which soc-for-v3.17 and boards-for-v3.17? are rebased on top of.
I believe this is a project for which I will need strong coffee as an assistant.
Quoted 43 lines
Quoted 2 lines
Please note that these are only lightly compile tested with a handful of defconfigs, but any potential issue should be trivial to fix.
Indeed. And it touches
arch/arm/mach-shmobileonly.Quoted 6 lines
Also, there are certain bits of
arch/arm/mach-shmobile/include/mach/get included from places likearch/arm/boot/compressed/(booting legacy kernel directly from reset vector) and also from SoC specific legacy code underdrivers/pinctrl. My proposal is to keep those users as-is until we phase out legacy board support (2-3 kernels?), let me know if you would like to get rid of "include/mach" sooner!It seems you forgot
r7s72100.h,r8a73a4.h, andsh73a0.h? Can just be moved, with #include update.Remaining are lots of files only used by
arch/arm/boot, so I'd move those (mmc*, sdhi*, zboot*) into .../boot.
mach/system.hseems to be unused?The parts of
irqs.hneeded for legacy pinctrl can be extracted intodrivers/pinctrl/sh-pfc/irqs_legacy.h, to be removed later. After thatirqs.hcan move, too.After that, we can see what's left...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.orgIn personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html