trace-seq/seq-buf/x86/printk: Print all stacks from NMI safely
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest26 patches 29 repliesIn review
- v4 RFC23 patches 34 repliesSuperseded
- v3 RFC12 patches 64 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 RFC | 4 of 5 patches | 28 replies | Superseded | |
| v1 RFC | 3 patches | 34 replies | Superseded |
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/26 | tracing: Fix trace_seq_bitmask() to start at current positionkernel/ | +1 | 0 replies | |
| 2/26 | tracing: Add trace_seq_has_overflowed() and trace_handle_return()include/ include/ include/ +4 more | +231 | 0 replies | |
| 3/26 | blktrace/tracing: Use trace_seq_has_overflowed() helper functionkernel/ | +66 | 0 replies | |
| 4/26 | ring-buffer: Remove check of trace_seq_{puts,printf}() return valueskernel/ | +36 | 0 replies | |
| 5/26 | tracing: Have branch tracer use trace_handle_return() helper functionkernel/ | +7 | 0 replies | |
| 6/26 | tracing: Have function_graph use trace_seq_has_overflowed()kernel/ kernel/ | +118 | 0 replies | |
| 7/26 | kprobes/tracing: Use trace_seq_has_overflowed() for overflow checkskernel/ | +16 | 1 reply | |
| 8/26 | tracing: Do not check return values of trace_seq_p*() for mmio tracerkernel/ | +21 | 1 reply | |
| 9/26 | tracing/probes: Do not use return value of trace_seq_printf()kernel/ | +6 | 1 reply | |
| 10/26 | tracing/uprobes: Do not use return values of trace_seq_printf()kernel/ | +10 | 3 replies | |
| 11/26 | tracing: Do not use return values of trace_seq_printf() in syscall tracingkernel/ | +15 | 0 replies | |
| 12/26 | tracing: Remove return values of most trace_seq_*() functionsinclude/ kernel/ | +38 | 1 reply | |
| 13/26 | tracing: Fix return value of ftrace_raw_output_prep()include/ kernel/ | +2 | 1 reply | |
| 14/26 | tracing: Create seq_buf layer in trace_seqinclude/ include/ kernel/ +5 more | +538 | 2 replies | |
| 15/26 | tracing: Convert seq_buf_path() to be like seq_path()include/ kernel/ kernel/ | +19 | 0 replies | |
| 16/26 | tracing: Convert seq_buf fields to be like seq_file fieldsinclude/ | +4 | 0 replies | |
| 17/26 | tracing: Add a seq_buf_clear() helper and clear len and readpos in initinclude/ | +7 | 0 replies | |
| 18/26 | seq_buf: Create seq_buf_used() to find out how much was writteninclude/ kernel/ | +7 | 3 replies | |
| 19/26 | tracing: Use trace_seq_used() and seq_buf_used() instead of leninclude/ kernel/ kernel/ +3 more | +60 | 15 replies | |
| 20/26 | seq_buf: Add seq_buf_can_fit() helper functionkernel/ | +10 | 12 replies | |
| 21/26 | tracing: Have seq_buf use full bufferinclude/ kernel/ | +9 | 0 replies | |
| 22/26 | tracing: Add seq_buf_get_buf() and seq_buf_commit() helper functionsinclude/ kernel/ | +44 | 0 replies | |
| 23/26 | seq-buf: Make seq_buf_bprintf() conditional on CONFIG_BINARY_PRINTFinclude/ kernel/ | +7 | 0 replies | |
| 24/26 | seq_buf: Move the seq_buf code to lib/kernel/ kernel/ lib/ +1 more | +352 | 0 replies | |
| 25/26 | printk: Add per_cpu printk func to allow printk to be divertedinclude/ include/ kernel/ | +34 | 0 replies | |
| 26/26 | x86/nmi: Perform a safe NMI stack trace on all CPUsarch/ | +86 | 1 reply |
Reviews trailers per patch
All 26 patches have a Reviewed-by or Acked-by.
| Patch | Petr Mladek | Jiri Kosina | Paul E. McKenney | Masami Hiramatsu | Srikar Dronamraju |
|---|---|---|---|---|---|
| 1/26 | R-b | ||||
| 2/26 | R-b | ||||
| 3/26 | R-b | ||||
| 4/26 | R-b | ||||
| 5/26 | R-b | ||||
| 6/26 | R-b | ||||
| 7/26 | R-b | A-b | R-b | ||
| 8/26 | R-b | ||||
| 9/26 | R-b | A-b | |||
| 10/26 | R-b | R-b | A-b | ||
| 11/26 | R-b | ||||
| 12/26 | R-b | ||||
| 13/26 | Reminded-by R-b | ||||
| 14/26 | R-b | T-b A-b | |||
| 15/26 | R-b | T-b A-b | |||
| 16/26 | R-b | T-b A-b | |||
| 17/26 | R-b | T-b A-b | |||
| 18/26 | R-b | ||||
| 19/26 | R-b R-b R-b | ||||
| 20/26 | R-b | ||||
| 21/26 | R-b | T-b A-b | |||
| 22/26 | R-b | T-b A-b | |||
| 23/26 | R-b | T-b A-b | |||
| 24/26 | R-b | T-b A-b | |||
| 25/26 | R-b | T-b A-b | A-b | ||
| 26/26 | R-b | T-b A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH 00/26 v5] trace-seq/seq-buf/x86/printk: Print all stacks from NMI safely
Version 5!
Full diff between v4 and v5 will be replied to this email.
Here's the summary of the differences since version 4:
. Various clean ups
. Added trace_seq_used() to be used instead of s->seq.len
. Used seq_buf_used() instead of s->len
. Fixed output of ftrace_raw_output_prep() as well as caller code
. Fixed up tracing_fill_pipe_page() The logic was a bit whacky
and this was needed when introducing trace_seq_used()
. Rebased on latest ftrace/core code
. Fixed uprobe to be like probe code in print_uprobe_event()
. Introduced new seq_buf_can_fit() to remove the likelyhood of
screwing up the s->len + * < s->size code. Now it's just seq_buf_can_fit(s, len) which will tell us if the len can still fit in the buffer.
Enjoy,
-- Steve
Steven Rostedt (Red Hat) (26):
tracing: Fix trace_seq_bitmask() to start at current position
tracing: Add trace_seq_has_overflowed() and trace_handle_return() blktrace/tracing: Use trace_seq_has_overflowed() helper function
ring-buffer: Remove check of trace_seq_{puts,printf}() return values
tracing: Have branch tracer use trace_handle_return() helper function
tracing: Have function_graph use trace_seq_has_overflowed() kprobes/tracing: Use trace_seq_has_overflowed() for overflow checks
tracing: Do not check return values of trace_seq_p*() for mmio tracer tracing/probes: Do not use return value of trace_seq_printf() tracing/uprobes: Do not use return values of trace_seq_printf()
tracing: Do not use return values of trace_seq_printf() in syscall tracing
tracing: Remove return values of most trace_seq_*() functions
tracing: Fix return value of ftrace_raw_output_prep()
tracing: Create seq_buf layer in trace_seq
tracing: Convert seq_buf_path() to be like seq_path()
tracing: Convert seq_buf fields to be like seq_file fields
tracing: Add a seq_buf_clear() helper and clear len and readpos in init
seq_buf: Create seq_buf_used() to find out how much was written
tracing: Use trace_seq_used() and seq_buf_used() instead of len
seq_buf: Add seq_buf_can_fit() helper function
tracing: Have seq_buf use full buffer
tracing: Add seq_buf_get_buf() and seq_buf_commit() helper functions
seq-buf: Make seq_buf_bprintf() conditional on CONFIG_BINARY_PRINTF
seq_buf: Move the seq_buf code to lib/
printk: Add per_cpu printk func to allow printk to be diverted x86/nmi: Perform a safe NMI stack trace on all CPUs
----
arch/x86/kernel/apic/hw_nmi.c | 91 +++++++- include/linux/ftrace_event.h | 11 + include/linux/percpu.h | 3 + include/linux/printk.h | 2 + include/linux/seq_buf.h | 136 ++++++++++++ include/linux/trace_seq.h | 77 ++++--- include/trace/ftrace.h | 8 +- kernel/printk/printk.c | 38 +++- kernel/trace/blktrace.c | 148 ++++++------- kernel/trace/ring_buffer.c | 75 +++---- kernel/trace/trace.c | 126 ++++++----- kernel/trace/trace.h | 3 +- kernel/trace/trace_branch.c | 15 +- kernel/trace/trace_events.c | 9 +- kernel/trace/trace_functions_graph.c | 393 +++++++++++---------------------- kernel/trace/trace_kprobe.c | 42 ++-- kernel/trace/trace_mmiotrace.c | 52 ++--- kernel/trace/trace_output.c | 417 ++++++++++++++--------------------- kernel/trace/trace_output.h | 16 +- kernel/trace/trace_probe.c | 10 +- kernel/trace/trace_seq.c | 253 +++++++++------------ kernel/trace/trace_syscalls.c | 43 ++-- kernel/trace/trace_uprobe.c | 23 +- lib/Makefile | 2 +- lib/seq_buf.c | 351 +++++++++++++++++++++++++++++ 25 files changed, 1323 insertions(+), 1021 deletions(-)