rcu: uninline rcu_read_lock_held()
Status from this message: Queued for 3.18, thank you, Oleg!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | rcu: uninline rcu_read_lock_held()include/ kernel/ | +34 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/1] rcu: uninline rcu_read_lock_held()
Quoted 4 lines · Oleg Nesterov
And this naturally suggests that
rcu_read_lock_held()should be uninlined too (andrcu_read_lock_sched_held(), but this needs another patch).
Quoted 8 lines
But I still can't understand the difference reported by "size vmlinux",
- 5541731 3014560 14757888 23314179
+ 5513182 3026848 14757888 23297918it removes 28K from .text, but somehow it adds 12K to .data. I do not see any difference in .data when I compare individual .o files before/ after this patch.
OK, it doesn't add to .data. This is because of INIT_TASK_DATA(THREAD_SIZE) in vmlinux.lds.S, see the changelog.
If you think this makes sense I will will spam you again. We can also uninline rcu_read_lock_sched_held(), mostly for consistency. But this needs a separate change.
Oleg.