Skip to content

uio_pruss: add support for devicetree and am33xx

Hans J. Koch linux-arm-kernel linux-devicetree linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 13 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 13 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/13] uio_pruss: add support for devicetree and am33xx
Quoted 26 lines · Paul Walmsley
Quoted 8 lines · Andre Heider
Quoted 7 lines · Andre Heider

this series adds PRUv2 support to uio_pruss through devicetree, makes the device usable on am33xx and enables it on beaglebone black. Inspired by old patches from Matt Porter found in a downstream tree.

To archieve that this series:
* adds a flag to omap_hwmod.c to get PRUSS out of hardreset (patch 5 and 6)

...

Quoted 6 lines
Quoted 6 lines

* is the hardreset thing I did there the right thing to do? I think the proper way would be a reset controller (which apparently doesn't yet exist for this SoC?) and let the driver deassert/assert on probe/remove?
* the platform device path has a clk_enable() / clk_put() calls. Are those now redundant with the introduced pm_runtime_enable() pm_runtime_disable() calls?

Probably you only need pm_runtime_{get,put}_*() calls, unless you're changing clock parents or rates in your driver code.

Quoted 2 lines

@OMAP guys: any comments? The series depends on patch 5 and 6; both touch common hwmod code.

Quoted 8 lines

I'd suggest splitting the series into three independent pieces if possible:

1. UIO code, for the UIO maintainer(s)
2. DT pieces for Tony
3. hwmod pieces for me

That way they can be cleanly merged by the respective maintainers.

I second that. At first sight, the UIO parts look OK to me, but please make it a new patch series.

Thanks,
Hans