Skip to content

staging:iio:hmc5843: Few adjustments and support for hmc5983

Josef Gajdusek linux-iio lkml 1 version In review

Get series with b4
b4 am 20140715122410.GA30770@dashie

Versions newest first

  1. v4 Latest0 of 5 patches 1 replyIn review

Changes in v4 from the cover letter

* Changes suggested by Lars in https://lkml.org/lkml/2014/7/14/968
* The i2c and spi drivers are now user-selectable with the core driver being selected automatically
* The regmap_config structs in both _spi and _i2c files are now static
* The iio_dev allocation is now done in the common function
* pm ops are now defined in the header file and the same definition is shared between both interface-specific drivers
* regmap tables in hmc5843.h are not longer static (this fixed bunch of variable not used warnings)

Patches in v4 No applies recorded yet

None of the 5 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/5] staging:iio:hmc5843: Few adjustments and support for hmc5983

This patch series modifies the hmc5843 driver to support the hmc5983 i2c and spi interfaces.

v2:
* Reverted the changed order of iio unregister and setting hmc mode to sleep

v3:
* Fixed bug introduced in the first patch
* Readded few comment lines which have gone missing in the hmc5843.c -> hmc5843_core.c move

v4:
* Changes suggested by Lars in https://lkml.org/lkml/2014/7/14/968
* The i2c and spi drivers are now user-selectable with the core driver being selected automatically
* The regmap_config structs in both _spi and _i2c files are now static
* The iio_dev allocation is now done in the common function
* pm ops are now defined in the header file and the same definition is shared between both interface-specific drivers
* regmap tables in hmc5843.h are not longer static (this fixed bunch of variable not used warnings)

Jonathan, the patch series applies cleanly against mainline (for me at least), maybe you already have some hmc5843 related patches in your tree which are not yet in upstream? (probably https://lkml.org/lkml/2014/2/14/312)

Josef Gajdusek (5):
staging:iio:hmc5843: Added regmap support staging:iio:hmc5843: Split hmc5843.c to multiple files staging:iio:hmc5843: register <-> value arrays now can have different
lengths
staging:iio:hmc5843: Add support for i2c hmc5983 staging:iio:hmc5843: Add support for spi hmc5983

 drivers/staging/iio/magnetometer/Kconfig        |  30 +-
 drivers/staging/iio/magnetometer/Makefile       |   4 +-
 drivers/staging/iio/magnetometer/hmc5843.c      | 652 ------------------------
 drivers/staging/iio/magnetometer/hmc5843.h      |  86 ++++
 drivers/staging/iio/magnetometer/hmc5843_core.c | 638 +++++++++++++++++++++++
 drivers/staging/iio/magnetometer/hmc5843_i2c.c  |  74 +++
 drivers/staging/iio/magnetometer/hmc5843_spi.c  |  73 +++
 7 files changed, 900 insertions(+), 657 deletions(-)
 delete mode 100644 drivers/staging/iio/magnetometer/hmc5843.c
 create mode 100644 drivers/staging/iio/magnetometer/hmc5843.h
 create mode 100644 drivers/staging/iio/magnetometer/hmc5843_core.c
 create mode 100644 drivers/staging/iio/magnetometer/hmc5843_i2c.c
 create mode 100644 drivers/staging/iio/magnetometer/hmc5843_spi.c
Signature · 1 line
1.8.5.5