ftrace: kill the dead code in trace_sched_switch.c
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | ftrace: Kill tracing_{start,stop}_sched_switch_record() and tracing_sched_switch_assign_trace()kernel/ kernel/ | +0 | 0 replies | |
| 2/2 | ftrace: Kill the dead code in probe_sched_switch() and probe_sched_wakeup()kernel/ | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] ftrace: kill the dead code in trace_sched_switch.c
Quoted 4 lines · Oleg Nesterov
This motivated me to try to find something else unused. And it seems that almost all code in
kernel/trace/trace_sched_switch.cis dead? Hmm, and probably evenevent_context_switch... I'll recheck and send the patch.
No, event_context_switch can't simply go away. But afaics the only user is tracing_sched_switch_trace(), and the only caller of this function is probe_wakeup_sched_switch(). Looks a bit strange.
After this patch we should probably move tracing_sched_switch_trace() and tracing_sched_wakeup_trace() from trace_sched_switch.c to trace_sched_wakeup.c and make them static. And perhaps we can also move the rest of this code somewhere else and rm this file...
Oleg.
kernel/trace/trace.h | 3 - kernel/trace/trace_sched_switch.c | 88 ------------------------------------- 2 files changed, 0 insertions(+), 91 deletions(-)