Skip to content

coverity mixed bag

Jeff King git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5receive-pack: don't copy "dir" parameterbuiltin/receive-pack.c+2 -20 replies
2/5free ref string returned by dwim_refbuiltin/rev-parse.c builtin/show-branch.c sha1_name.c+5 -10 replies
3/5transport: fix leaks in refs_from_alternate_cbtransport.c+3 -20 replies
4/5fix memory leak parsing core.commentcharconfig.c+5 -70 replies
5/5apply: avoid possible bogus pointerbuiltin/apply.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] coverity mixed bag

Since Stefan has recently started feeding git builds to coverity, I spent a few minutes poking through the results. There are tons of false positives, so there is some work to be done there with tweaking our coverity models. But there are some real issues, too. Here are fixes for the handful that I looked at.

[1/5]: receive-pack: don't copy "dir" parameter [2/5]: free ref string returned by dwim_ref [3/5]: transport: fix leaks in refs_from_alternate_cb [4/5]: fix memory leak parsing core.commentchar [5/5]: apply: avoid possible bogus pointer

-Peff