/proc/PID/*maps* fixes/cleanups
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 15 repliesIn review
- v15 patches 3 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | fs/proc/task_mmu.c: don't use task->mm in m_start() and show_*map()fs/ | +3 | 3 replies | |
| 2/7 | fs/proc/task_mmu.c: unify/simplify do_maps_open() and numa_maps_open()fs/ | +16 | 1 reply | |
| 3/7 | proc: introduce proc_mem_open()fs/ fs/ | +23 | 1 reply | |
| 4/7 | fs/proc/task_mmu.c: shift mm_access() from m_start() to proc_maps_open()fs/ fs/ | +29 | 5 replies | |
| 5/7 | fs/proc/task_mmu.c: simplify the vma_stop() logicfs/ | +18 | 1 reply | |
| 6/7 | fs/proc/task_mmu.c: cleanup the "tail_vma" horror in m_next()fs/ | +3 | 1 reply | |
| 7/7 | fs/proc/task_mmu.c: shift "priv->task = NULL" from m_start() to m_stop()fs/ | +3 | 1 reply |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Kirill A. Shutemov | Cyrill Gorcunov | Greg Ungerer |
|---|---|---|---|
| Series | T-b | A-b | A-b |
| 1/7 | A-b | ||
| 2/7 | A-b | ||
| 3/7 | A-b | ||
| 4/7 | A-b | ||
| 5/7 | A-b | ||
| 6/7 | A-b | ||
| 7/7 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 0/7] /proc/PID/*maps* fixes/cleanups
Changes:
1-4: Update the changelogs, join "introduce the stable
proc_maps_private->mm" and "change m_start() to rely on priv->mm" into a single "shift "priv->task = NULL" from m_start() to m_stop()".
Resulting code is the same. Kirill and Cyrill, you seem to agree with these changes, I'll appreciate your acks.
5-7: New. Seems to work, please review.
Todo:
- Cleanup the tail_vma horror in m_start
- Update task_nommu.c in the same way
- Fix lock_trace() users
Oleg.
fs/proc/base.c | 36 ++++++++------ fs/proc/internal.h | 3 + fs/proc/task_mmu.c | 136 ++++++++++++++++++++++++++------------------------- 3 files changed, 93 insertions(+), 82 deletions(-)