Skip to content

fs/proc/task_mmu.c: cleanup tail_vma/last_addr mess

Oleg Nesterov linux-fsdevel lkml netdev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5fs/proc/task_mmu.c: kill the suboptimal and confusing m->version logicfs/proc/task_mmu.c+1 -340 replies
2/5fs/proc/task_mmu.c: simplify m_start() to make it readablefs/proc/task_mmu.c+10 -240 replies
3/5fs/proc/task_mmu.c: introduce m_next_vma() helperfs/proc/task_mmu.c+10 -50 replies
4/5fs/proc/task_mmu.c: reintroduce m->version logicfs/proc/task_mmu.c+21 -00 replies
5/5fs/proc/task_mmu.c: update m->version in the main loop in m_start()fs/proc/task_mmu.c+4 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] fs/proc/task_mmu.c: cleanup tail_vma/last_addr mess
Quoted 4 lines · Oleg Nesterov

Todo:

- Cleanup the tail_vma horror in m_start

On top of the previous "[PATCH v2 0/7] /proc/PID/*maps* fixes/cleanups" series.

It took me much more time than I expected ;) And after 3 attempts I failed to fix this (imho) horror step-by-step. So 1/5 simply removes the last_addr code, and then 4/5 brings it back.

Todo:

- Update task_nommu.c in the same way

- Fix lock_trace() users

Oleg.

 fs/proc/task_mmu.c |   98 +++++++++++++++++++++------------------------------
 1 files changed, 40 insertions(+), 58 deletions(-)