Skip to content

RFC introduce proc_inode->pid_entry

Oleg Nesterov linux-fsdevel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5proc: intoduce proc_inode->pid_entry and is_tgid_pid_entry()fs/proc/base.c fs/proc/inode.c fs/proc/internal.h+20 -13 replies
2/5proc: unify proc_tgid_stat() and proc_tid_stat()fs/proc/array.c fs/proc/base.c fs/proc/internal.h+6 -190 replies
3/5proc: kill *_tid_*maps* stufffs/proc/base.c fs/proc/internal.h fs/proc/task_mmu.c+25 -1250 replies
4/5proc: introduce pid_entry_name()fs/proc/base.c fs/proc/internal.h+8 -00 replies
5/5proc: unify proc_pid_*maps* stufffs/proc/base.c fs/proc/internal.h fs/proc/task_mmu.c+54 -800 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/5] introduce proc_inode->pid_entry

Hello,

Obviously not for inclusion. The patches are horrible, break task_nommu.c, untested, etc. Only to explain what I mean and discuss the intent, at least. On top of recent /proc/pid/*maps* cleanups I sent.

To me it looks a bit annoying that task_mmu.c needs 6 seq_operations's and 6 file_operations's to handle /proc/pid/*maps*. And _only_ because ->show() differs.

Eric, et al, what do you think? At least something like 1-3 looks like a good cleanup imho. And afaics we can do more cleanups on top.

Oleg.

 fs/proc/array.c    |   17 +---
 fs/proc/base.c     |   37 +++++++--
 fs/proc/inode.c    |    1 +
 fs/proc/internal.h |   16 ++--
 fs/proc/task_mmu.c |  237 +++++++++++++---------------------------------------
 5 files changed, 98 insertions(+), 210 deletions(-)