Skip to content

Fixing hardware migration issues

Pavel Dovgalyuk qemu-devel 2 versions – In review

Get series with b4
b4 am 20140828111822.1624.24556.stgit@PASHA-ISP

Versions newest first · linked by author and title

  1. v2 Latest12 patches 9 repliesIn review
  2. v112 patches 23 repliesSuperseded

Changes in v2 from the cover letter

* Used vmsd field of device classes instead of vm_state_register function (as suggested by Paolo Bonzini)
* Added more comments describing piix migration fix (as suggested by Paolo Bonzini)
* Some fields' initializations moved from pre_load to reset functions (as suggested by Paolo Bonzini)
* Removed patch of the rtl8139 module, because irq problem is solved by another patches (as suggested by Paolo Bonzini)
* Changed paddr synchronization in vapic (as suggested by Paolo Bonzini)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12integratorcp: adding vmstate for save/restorehw/arm/integratorcp.c+37 -11 reply
2/12pcspk: adding vmstate for save/restorehw/audio/pcspk.c+15 -21 reply
3/12fdc: adding vmstate for save/restorehw/block/fdc.c+74 -00 replies
4/12parallel: adding vmstate for save/restorehw/char/parallel.c+19 -00 replies
5/12serial: fixing vmstate for save/restorehw/char/serial.c+220 -450 replies
6/12apic_common: fixing loading vmstatehw/intc/apic_common.c+24 -01 reply
7/12apic_common: vapic_paddr synchronization fixhw/intc/apic_common.c+9 -10 replies
8/12hpet: fixing saving and loading processhw/timer/hpet.c+2 -133 replies
9/12pckbd: adding new fields to vmstatehw/input/pckbd.c+51 -00 replies
10/12piix: do not raise irq while loading vmstatehw/pci-host/piix.c+24 -20 replies
11/12mc146818rtc: add missed field to vmstatehw/timer/mc146818rtc.c+25 -00 replies
12/12pl031: add missed field to vmstatehw/timer/pl031.c+2 -12 replies

Reviews trailers per patch

1 of 12 patches has a Reviewed-by or Acked-by.

PatchPaolo Bonzini
1/12
2/12
3/12
4/12
5/12
6/12
7/12
8/12
9/12R-b
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 00/12] Fixing hardware migration issues

This set of patches is related to migration issues in hardware devices. Some of the devices had fields in their states that didn't saved and restored. These patches add missed fields to the new subsections of the vmstates. For several devices (like integratorcp) the patches add new vmstates, that didn't exist at all.

v2 changes:
* Used vmsd field of device classes instead of vm_state_register function (as suggested by Paolo Bonzini)
* Added more comments describing piix migration fix (as suggested by Paolo Bonzini)
* Some fields' initializations moved from pre_load to reset functions (as suggested by Paolo Bonzini)
* Removed patch of the rtl8139 module, because irq problem is solved by another patches (as suggested by Paolo Bonzini)
* Changed paddr synchronization in vapic (as suggested by Paolo Bonzini)

---

Pavel Dovgalyuk (12):
integratorcp: adding vmstate for save/restore
pcspk: adding vmstate for save/restore
fdc: adding vmstate for save/restore
parallel: adding vmstate for save/restore
serial: fixing vmstate for save/restore
apic_common: fixing loading vmstate
apic_common: vapic_paddr synchronization fix
hpet: fixing saving and loading process
pckbd: adding new fields to vmstate
piix: do not raise irq while loading vmstate
mc146818rtc: add missed field to vmstate
pl031: add missed field to vmstate

 hw/arm/integratorcp.c  |   38 +++++++
 hw/audio/pcspk.c       |   17 +++
 hw/block/fdc.c         |   74 +++++++++++++
 hw/char/parallel.c     |   19 +++
 hw/char/serial.c       |  265 ++++++++++++++++++++++++++++++++++++++++--------
 hw/input/pckbd.c       |   51 +++++++++
 hw/intc/apic_common.c  |   34 ++++++
 hw/pci-host/piix.c     |   26 ++++-
 hw/timer/hpet.c        |   15 ---
 hw/timer/mc146818rtc.c |   25 +++++
 hw/timer/pl031.c       |    3 -
 11 files changed, 502 insertions(+), 65 deletions(-)
Signature · 1 line
Pavel Dovgalyuk