Skip to content

name_decoration cleanups

Jeff King git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3log-tree: make add_name_decoration a public functionbisect.c commit.h log-tree.c+17 -142 replies
2/3log-tree: make name_decoration hash staticcommit.h log-tree.c revision.c+10 -53 replies
3/3log-tree: use FLEX_ARRAY in name_decorationcommit.h log-tree.c+2 -21 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] name_decoration cleanups
Quoted 4 lines · Junio C Hamano
Quoted 2 lines · Jeff King

On Mon, Aug 25, 2014 at 11:26:39AM -0700, Junio C Hamano wrote:

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Good digging, and I agree that it should use the FLEX_ARRAY for consistency.

I can produce a patch, but I did not want to steal Arjun's thunder.

Hmph, would it have to overlap? I think we can queue Arjun's patch with +1 fix and FLEX_ARRAY thing separately, and they can go in in any order, no?

I more meant my suggestion to use add_name_decoration consistently. That fixes the r->type thing _and_ replaces Arjun's patch. Fixing FLEX_ARRAY on top is just gravy. :)

Here's the patch series I was thinking of:

[1/3]: log-tree: make add_name_decoration a public function [2/3]: log-tree: make name_decoration hash static [3/3]: log-tree: use FLEX_ARRAY in name_decoration

I almost added a 4/3 to convert "name_decoration" to "commit_decoration", since that is how it is used (and name_decoration is somewhat vague). But we actually do annotate other non-commit objects that refs point to, as well. I'm not sure there is a way to _show_ them currently, but I'd just as soon leave it as-is.

-Peff