Skip to content

Fix arm64 issues highlighted by sparse and smatch

Christoffer Dall linux-arm-kernel 1 version New

Get series with b4
b4 am 20140826145614.GE6689@cbox

Versions newest first

  1. v1 Latest5 of 11 patches 0 repliesNew

5 of 11 patches are in this archive. The cover letter announces 11.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11KVM: ARM/arm64: fix non-const declaration of function returning const+0 -00 replies
3/11KVM: ARM/arm64: avoid returning negative error code as bool+0 -00 replies
4/11KVM: ARM/arm64: return -EFAULT if copy_from_user fails in set_timer_reg+0 -00 replies
5/11KVM: vgic: return int instead of bool when checking I/O ranges+0 -00 replies
6/11KVM: vgic: declare probe function pointer as const+0 -00 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchChristoffer Dall
1/11A-b
3/11A-b
4/11A-b
5/11A-b
6/11A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] Fix arm64 issues highlighted by sparse and smatch
Quoted 9 lines · Will Deacon

Hi all,

After the static checking talk at kernel summit, I felt empowered to go and run sparse and smatch over the arm64 defconfig. As I anticipated, this spotted a few issues in the arch code, so I've fixed up the ones that aren't just noise in this series. Most are simply incorrect address space annotations, but fixing these is useful for spotting real issues in the future.

Quoted 4 lines

I don't think any of these fix critical bugs, but they all deserve to be addressed. I tagged the compat watchpoint fix for stable, as that code has been broken since we merged the architecture port.

Thanks for these!

Do you want me to queue the kvm ones or did you have other plans to upstream this entire series as one?

Also, do you consider these fixes for 3.17 (what about cc for stable in that case), or for 3.18?

-Christoffer