sunvnet: Reduce LDC message overhead.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 15 repliesIn review
- v12 patches 8 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | Avoid sending superfluous LDC messages.drivers/ drivers/ | +63 | 0 replies | |
| 2/2 | Re-check for a VIO_DESC_READY data descriptor after short udelay()drivers/ | +20 | 9 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Raghuram Kothakota |
|---|---|
| 1/2 | A-b |
| 2/2 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v2 0/2] sunvnet: Reduce LDC message overhead.
This patchset has an updated version of the v1 changes to reduce the overhead from LDC messages.
Re-submitting both patches for completeness.
- Send the minimum number of start and stop messages between producer and consumer.
Changes since v1 to pull out the unused label again' and the unused retries' variable
- When reading the descriptor rings, don't give up as soon as a dring that is not VIO_DESC_READY is found.
Changes since v1: the `again' label and retries variable belong to this patch.
I understand the Puristic objection to the polling-delay from patch 2/2, but the practical reality is that when there is a burst of data, and performance is actually most critical, the overhead from hastily sending an LDC stop and then processing another LDC start message is far greater than the slight penalty of a small delay when the network traffic is light.
Note that I'm separately working on moving the data handling to a bottom-half or softirq context, where the poll-based delay will be even less critical. We could also consider adding a procfs or ethtool based knob to disable the fudge-factored delay, and avoid the minor polling penalty.
Sowmini Varadhan (2):
Avoid sending superfluous LDC messages.
Re-check for a VIO_DESC_READY data descriptor after short udelay()
drivers/net/ethernet/sun/sunvnet.c | 87 ++++++++++++++++++++++++++++++++++---- drivers/net/ethernet/sun/sunvnet.h | 4 ++ 2 files changed, 83 insertions(+), 8 deletions(-)
Signature · 1 line
1.8.4.2