Skip to content

clk: sun6i: Unify AHB1 clock and fix rate calculation

Maxime Ripard linux-arm-kernel linux-devicetree 1 version New

Get series with b4
b4 am 20140911203623.GJ31276@lukather

Versions newest first

  1. v1 Latest7 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7clk: sunxi: Add post clk divider for factor clocks+0 -00 replies
1/7clk: sunxi: Add post clk divider for factor clocks+0 -01 reply
1/7clk: sunxi: Add post clk divider for factor clocks+0 -01 reply
2/7clk: sunxi: Fix PLL6 calculation on sun6i+0 -00 replies
3/7clk: sunxi: unify sun6i AHB1 clock with proper PLL6 pre-divider+0 -01 reply
3/7clk: sunxi: unify sun6i AHB1 clock with proper PLL6 pre-divider+0 -01 reply
3/7clk: sunxi: unify sun6i AHB1 clock with proper PLL6 pre-divider+0 -00 replies
6/7ARM: dts: sun6i: Add required ahb1 clock parent and rates for dma controller+0 -01 reply
6/7ARM: dts: sun6i: Add required ahb1 clock parent and rates for dma controller+0 -01 reply
6/7ARM: dts: sun6i: Add required ahb1 clock parent and rates for dma controller+0 -01 reply
6/7ARM: dts: sun6i: Add required ahb1 clock parent and rates for dma controller+0 -00 replies
7/7dmaengine: sun6i: Remove obsolete clk muxing code+0 -00 replies

Reviews trailers per patch

5 of 12 patches have a Reviewed-by or Acked-by.

PatchMaxime Ripard
1/7A-b
1/7A-b
1/7A-b
2/7A-b
3/7
3/7
3/7
6/7
6/7
6/7
6/7
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] clk: sun6i: Unify AHB1 clock and fix rate calculation

Hi Chen-Yu,

Quoted 24 lines · Chen-Yu Tsai

Hi everyone,

This series unifies the mux and divider parts of the AHB1 clock found on sun6i and sun8i, while also adding support for the pre-divider on the PLL6 input.

The rate calculation logic must factor in which parent it is using to calculate the rate, to decide whether to use the pre-divider or not. This is beyond the original factors clk design in sunxi. To avoid feature bloat, this is implemented as a seperate composite clk.

The new clock driver is registered with a separate OF_CLK_DECLARE. This is done so that assigned-clocks* properties on the clk provider node can actually work. The clock framework arranges the clock setup order by checking whether all clock parents are available, by checking the node matching OF_CLK_DECLARE.

However, the sunxi clk driver is based on the root node compatible, has no defined dependencies (parents), and is setup before the fixed-rate clocks. Thus when the ahb1 clock is added, all parents have rate = 0. There is no way to calculate the required clock factors to set a default clock rate under these circumstances. This happens when we set the defaults in the clock node (provider), rather than a clock consumer.

Quoted 4 lines

I can think of 2 ways to solve the dependency issue, but neither is pretty. One would be to move the root fixed-rate clocks into the sunxi clk driver. The other would be separating all the clocks into individual OF_CLK_DECLARE statements, which adds a lot of boilerplate code.

I don't know what Mike thinks of this, but I'd prefer the second.

Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140911/c5b977f3/attachment.sig>