Skip to content

Remove possible deadlocks in nfs_release_page()

NeilBrown linux-fsdevel linux-mm linux-nfs lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4SCHED: add some "wait..on_bit...timeout()" interfaces.include/linux/pagemap.h include/linux/wait.h kernel/sched/wait.c +1 more+55 -13 replies
2/4MM: export page_wakeup functionsinclude/linux/pagemap.h mm/filemap.c+10 -80 replies
3/4NFS: avoid deadlocks with loop-back mounted NFS filesystems.fs/nfs/file.c fs/nfs/write.c+16 -102 replies
4/4NFS/SUNRPC: Remove other deadlock-avoidance mechanisms in nfs_release_page()fs/nfs/file.c net/sunrpc/sched.c net/sunrpc/xprtrdma/transport.c +1 more+7 -234 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchPeter Zijlstra (Intel)
1/4A-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Remove possible deadlocks in nfs_release_page()

Because nfs_release_page() submits a 'COMMIT' nfs request and waits for it to complete, and does this during memory reclaim, it is susceptible to deadlocks if memory allocation happens anywhere in sending the COMMIT message. If the NFS server is on the same host (i.e. loop-back NFS), then any memory allocations in the NFS server can also cause deadlocks.

nfs_release_page() already has some code to avoid deadlocks in some circumstances, but these are not sufficient for loopback NFS.

This patch set changes the approach to deadlock avoidance. Rather than detecting cases that could deadlock and avoiding the COMMIT, it always tries the COMMIT, but only waits a short time (1 second). This avoid any deadlock possibility at the expense of not waiting longer than 1 second even if no deadlock is pending.

nfs_release_page() does not *need* to wait longer - all callers that matter handle a failure gracefully - they move on to other pages.

This set:
- adds some "_timeout()" functions to "wait_on_bit". Only a wait_on_page version is actually used.
- exports page wake_up support. NFS knows that the COMMIT is complete when PG_private is clear. So nfs_release_page will use wait_on_page_bit_killable_timeout to wait for the bit to clear, and needs access to wake_up_page()
- changes nfs_release_page() to use wait_on_page_bit_killable_timeout()
- removes the other deadlock avoidance mechanisms from nfs_release_page, so that PF_FSTRANS is again only used by XFS.

As such, it needs buy-in from sched people, mm people, and NFS people. Assuming I get that buy-in, suggests for how these patches can flow into mainline would be appreciated ... I daren't hope they can all go in through one tree....

Thanks,
NeilBrown

---

NeilBrown (4):
SCHED: add some "wait..on_bit...timeout()" interfaces.
MM: export page_wakeup functions
NFS: avoid deadlocks with loop-back mounted NFS filesystems. NFS/SUNRPC: Remove other deadlock-avoidance mechanisms in nfs_release_page()

 fs/nfs/file.c                   |   22 ++++++++++++----------
 fs/nfs/write.c                  |    2 ++
 include/linux/pagemap.h         |   12 ++++++++++--
 include/linux/wait.h            |    5 ++++-
 kernel/sched/wait.c             |   36 ++++++++++++++++++++++++++++++++++++
 mm/filemap.c                    |   21 +++++++++++++++------
 net/sunrpc/sched.c              |    2 --
 net/sunrpc/xprtrdma/transport.c |    2 --
 net/sunrpc/xprtsock.c           |   10 ----------
 9 files changed, 79 insertions(+), 33 deletions(-)
Signature · 7 lines
Signature

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected].  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>