Skip to content

Remove possible deadlocks in nfs_release_page() - V2

NeilBrown linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 of 4 patches 2 repliesIn review

2 of 4 patches are in this archive. The cover letter announces 4.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
3/4NFS: avoid deadlocks with loop-back mounted NFS filesystems.fs/nfs/file.c fs/nfs/write.c+27 -102 replies
4/4NFS/SUNRPC: Remove other deadlock-avoidance mechanisms in nfs_release_page()fs/nfs/file.c net/sunrpc/sched.c net/sunrpc/xprtrdma/transport.c +1 more+6 -220 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Remove possible deadlocks in nfs_release_page() - V2

These two patches are updated versions of the last two patches of this series. They include the use of congestion to avoid excessive waiting.

(I'm not resenting 1/4 and 2/4, they are unchanged).

Without the congestion check, I've seen wait times in try_to_free_pages as long as 208 seconds.
With no waiting at all in nfs_release_page() I've seen wait times as long as 1.4 seconds.
With the 1 second wait, I've seen 2 seconds.
These numbers will vary based on numerous factors, but it does seem to suggest that 1 second is a good ball-park number.

NeilBrown

---

NeilBrown (2):
NFS: avoid deadlocks with loop-back mounted NFS filesystems. NFS/SUNRPC: Remove other deadlock-avoidance mechanisms in nfs_release_page()

 fs/nfs/file.c                   |   28 ++++++++++++++++++----------
 fs/nfs/write.c                  |    7 +++++++
 net/sunrpc/sched.c              |    2 --
 net/sunrpc/xprtrdma/transport.c |    2 --
 net/sunrpc/xprtsock.c           |   10 ----------
 5 files changed, 25 insertions(+), 24 deletions(-)
Signature · 1 line
Signature