clk: sun6i: Unify AHB1 clock and fix rate calculation
Get series with b4
b4 am 20140926002544.19023.39287@quantumVersions newest first
- v1 Latest1 of 7 patches 0 repliesNew
1 of 7 patches is in this archive. The cover letter announces 7.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 3/7 | clk: sunxi: unify sun6i AHB1 clock with proper PLL6 pre-divider | +0 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/7] clk: sun6i: Unify AHB1 clock and fix rate calculation
Quoting Maxime Ripard (2014-09-11 13:36:23)
Quoted 27 lines
Hi Chen-Yu,
Quoted 24 lines · Chen-Yu Tsai
Hi everyone,
This series unifies the mux and divider parts of the AHB1 clock found on sun6i and sun8i, while also adding support for the pre-divider on the PLL6 input.
The rate calculation logic must factor in which parent it is using to calculate the rate, to decide whether to use the pre-divider or not. This is beyond the original factors clk design in sunxi. To avoid feature bloat, this is implemented as a seperate composite clk.
The new clock driver is registered with a separate
OF_CLK_DECLARE. This is done so that assigned-clocks* properties on the clk provider node can actually work. The clock framework arranges the clock setup order by checking whether all clock parents are available, by checking the node matchingOF_CLK_DECLARE.However, the sunxi clk driver is based on the root node compatible, has no defined dependencies (parents), and is setup before the fixed-rate clocks. Thus when the ahb1 clock is added, all parents have rate = 0. There is no way to calculate the required clock factors to set a default clock rate under these circumstances. This happens when we set the defaults in the clock node (provider), rather than a clock consumer.
Quoted 6 lines
Quoted 4 lines
I can think of 2 ways to solve the dependency issue, but neither is pretty. One would be to move the root fixed-rate clocks into the sunxi clk driver. The other would be separating all the clocks into individual
OF_CLK_DECLAREstatements, which adds a lot of boilerplate code.I don't know what Mike thinks of this, but I'd prefer the second.
I do not fully understand the problem. Ideally the clock driver should have some way to fail with EPROBE_DEFER until the fixed-rate clocks are registered. Those fixed-rate parents are enumerated in your dts, right? Why isn't this enough?
Thanks,
Mike
Quoted 7 lines
Maxime
Signature · 3 lines
Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com