Skip to content

KVM: handling of MMIO pass-through regions

Christoffer Dall linux-arm-kernel 1 version New

Get series with b4
b4 am 20140929130745.GF3095@cbox

Versions newest first

  1. v1 Latest6 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6arm/arm64: KVM: use __GFP_ZERO not memset() to get zeroed pages+0 -00 replies
2/6arm/arm64: KVM: fix potential NULL dereference in user_mem_abort()+0 -00 replies
2/6arm/arm64: KVM: fix potential NULL dereference in user_mem_abort()+0 -01 reply
3/6arm/arm64: KVM: add 'writable' parameter to kvm_phys_addr_ioremap+0 -01 reply
3/6arm/arm64: KVM: add 'writable' parameter to kvm_phys_addr_ioremap+0 -00 replies
3/6arm/arm64: KVM: add 'writable' parameter to kvm_phys_addr_ioremap+0 -00 replies
4/6ARM: kvm: define PAGE_S2_DEVICE as read-only by default+0 -00 replies
5/6arm64: kvm: define PAGE_S2_DEVICE as read-only by default+0 -01 reply
6/6arm/arm64: KVM: map MMIO regions at creation time+0 -00 replies

Reviews trailers per patch

5 of 9 patches have a Reviewed-by or Acked-by.

PatchChristoffer DallMarc Zyngier
1/6A-b
2/6A-b
2/6A-b
3/6
3/6
3/6
4/6A-b
5/6A-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] KVM: handling of MMIO pass-through regions
Quoted 23 lines · Ard Biesheuvel

This is a followup to the patches 'kvm: define PAGE_S2_DEVICE as read-only by default' I sent out last week. Essentially build tested
only: while QEMU on KVM still works correctly for my use case with these patches applied, it does not in fact use passthrough mappings of device memory.

Patch #1 is a trivial fix for an issue identified by sparse where we are calling memset(0) on 2 MB worth of pages.

Patch #2 fixes a potential NULL dereference in user_mem_abort()

Patch #3 adds a 'writable' parameter to kmv_phys_addr_ioremap() so that read-only device regions can be mapped using this function. The existing callers are updated to pass 'true' for this parameter.

Patch #4 and #5 were sent out before, and change the value of PAGE_S2_DEVICE to read-only, so that read-only regions can be ioremap()'ed

Patch #6 ensures that VM_PFNMAP linear mappings of non-system RAM host memory are mapped eagerly rather than faulted in page by page.

Quoted 8 lines

Ard Biesheuvel (6):
arm/arm64: KVM: use __GFP_ZERO not memset() to get zeroed pages arm/arm64: KVM: fix potential NULL dereference in user_mem_abort() arm/arm64: KVM: add 'writable' parameter to kvm_phys_addr_ioremap
ARM: kvm: define PAGE_S2_DEVICE as read-only by default
arm64: kvm: define PAGE_S2_DEVICE as read-only by default arm/arm64: KVM: map MMIO regions at creation time

So I only had comments on that last one and the others are fairly benign and small patches, so assuming the arch maintainers don't complain about the mm header changes, I can queue the first 5 patches and add the last one when we sort that out.

Thanks,
-Christoffer