Skip to content

MIPS executable stack protection

Leonid Yegoshin linux-mips lkml 4 versions – NAK

Status from this message: NAK.

Get series with b4
b4 am 20150805234348.20722.71740.stgit@ubuntu-yegoshin

Versions newest first · linked by author and title

  1. v4 Latest3 patches 11 repliesNAK
  2. v33 patches 7 repliesSuperseded
  3. v23 patches 14 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches10 repliesSuperseded

Changes in v4 from the cover letter

- Fixed bug in supplementary TLB flush (change KVA to user address space)
- Rebased to 4.X kernel
---

Patches in v4

#Subject and filesSizeRepliesApplied
1/3MIPS: mips_flush_cache_range is addedarch/mips/include/asm/cacheflush.h arch/mips/mm/c-octeon.c arch/mips/mm/c-r3k.c +3 more+75 -00 replies
2/3MIPS: Setup an instruction emulation in VDSO protected page instead of user stackarch/mips/include/asm/fpu_emulator.h arch/mips/include/asm/mmu.h arch/mips/include/asm/processor.h +12 more+267 -350 replies
3/3MIPS: set stack/data protection as non-executablearch/mips/include/asm/page.h+1 -19 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/3] MIPS executable stack protection

The following series implements an executable stack protection in MIPS.

It sets up a per-thread 'VDSO' page and appropriate TLB support. Page is set write-protected from user and is maintained via kernel VA. MIPS FPU emulation is shifted to new page and stack is relieved for execute protection as is as all data pages in default setup during ELF binary initialization. The real protection is controlled by GLIBC and it can do stack protected now as it is done in other architectures and I learned today that GLIBC team is ready for this.

Note: actual execute-protection depends from HW capability, of course.

This patch is required for MIPS32/64 R2 emulation on MIPS R6 architecture. Without it 'ssh-keygen' crashes pretty fast on attempt to execute instruction in stack.

v2 changes:
- Added an optimization during mmap switch - doesn't switch if the same thread is rescheduled and other threads don't intervene (Peter Zijlstra)
- Fixed uMIPS support (Paul Burton)
- Added unwinding of VDSO emulation stack at signal handler invocation, hiding an emulation page (Andy Lutomirski note in other patch comments)

V3 change: heavy preemption friendly.

V4 changes:
- Fixed bug in supplementary TLB flush (change KVA to user address space)
- Rebased to 4.X kernel
---

Leonid Yegoshin (3):
MIPS: mips_flush_cache_range is added
MIPS: Setup an instruction emulation in VDSO protected page instead of user stack
MIPS: set stack/data protection as non-executable

 arch/mips/include/asm/cacheflush.h    |    3 +
 arch/mips/include/asm/fpu_emulator.h  |    2 
 arch/mips/include/asm/mmu.h           |    3 +
 arch/mips/include/asm/page.h          |    2 
 arch/mips/include/asm/processor.h     |    2 
 arch/mips/include/asm/switch_to.h     |   14 +++
 arch/mips/include/asm/thread_info.h   |    3 +
 arch/mips/include/asm/tlbmisc.h       |    1 
 arch/mips/include/asm/vdso.h          |    3 +
 arch/mips/kernel/mips-r2-to-r6-emul.c |   10 +-
 arch/mips/kernel/process.c            |    7 ++
 arch/mips/kernel/signal.c             |    4 +
 arch/mips/kernel/vdso.c               |   44 +++++++++
 arch/mips/math-emu/cp1emu.c           |    8 +-
 arch/mips/math-emu/dsemul.c           |  154 +++++++++++++++++++++++++++------
 arch/mips/mm/c-octeon.c               |    8 ++
 arch/mips/mm/c-r3k.c                  |    8 ++
 arch/mips/mm/c-r4k.c                  |   43 +++++++++
 arch/mips/mm/c-tx39.c                 |    9 ++
 arch/mips/mm/cache.c                  |    4 +
 arch/mips/mm/fault.c                  |    5 +
 arch/mips/mm/tlb-r4k.c                |   42 +++++++++
 22 files changed, 343 insertions(+), 36 deletions(-)

--
Signature