Skip to content

sunvnet: NAPI enhancements.

Sowmini Varadhan netdev sparclinux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v5 Latest4 patches 2 repliesIn review

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4sunvnet: NAPIfy sunvnetdrivers/net/ethernet/sun/sunvnet.c drivers/net/ethernet/sun/sunvnet.h+137 -441 reply
2/4sunvnet: Use RCU to synchronize port usage with vnet_port_remove()drivers/net/ethernet/sun/sunvnet.c+33 -290 replies
3/4sparc64: Avoid irqsave/restore on vio.lock if in_softirq()arch/sparc/kernel/viohs.c+5 -31 reply
4/4sunvnet: Remove irqsave/irqrestore on vio.lockdrivers/net/ethernet/sun/sunvnet.c+5 -250 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchRaghuram KothakotaDwight EngenBob Picco
1/4A-b A-b
2/4A-b A-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCHv5 net-next 0/4] sunvnet: NAPI enhancements.

This patchset converts the sunvnet driver to use the NAPI framework. Changes since v4 to (Patch 1):
vnet_event accumulates LDC_EVENT_* bits into rx_event. vnet_event_napi() unrolls send_events() logic to process all rx_event bits.
(Mail Subject of cover-letter changed, to keep it distinct from subject of patch 1)

Patch 1 in the series addresses the packet-receive path- all the vnet_event() processing is moved into NAPI context. This patch is dependant on the sparc-next commit:
"sparc64: Add vio_set_intr() to enable/disable Rx interrupts" (sparc commit id ca605b7dd740c8909408d67911d8ddd272c2b320)

Patch 2 uses RCU to fix race conditions between vnet_port_remove and paths that access/modify port-related state, such as vnet_start_xmit.

Patch 3 and Patch 4 in the series leverage from the NAPIfied Rx path, dropping superfluous usage of the irqsave/irqrestores on the vio.lock where possible.

Note: Patch 3 contains changes that target sparc-next, Patch 4 targets net-next.

Sowmini Varadhan (4):
NAPIfy sunvnet
Use RCU to synchronize port usage with vnet_port_remove() Avoid irqsave/restore on vio.lock if in_softirq() Remove irqsave/irqrestore on vio.lock

 arch/sparc/kernel/viohs.c          |   8 +-
 drivers/net/ethernet/sun/sunvnet.c | 265 +++++++++++++++++++++++--------------
 drivers/net/ethernet/sun/sunvnet.h |   6 +-
 3 files changed, 179 insertions(+), 100 deletions(-)
Signature · 1 line
1.8.4.2