Skip to content

Improve silent builds

Thomas Petazzoni buildroot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest0 of 3 patches 0 repliesNew

Patches in v3 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Buildroot] [PATCH v3 0/3] Improve silent builds

Dear Fabio Porcedda,

Quoted 5 lines · Fabio Porcedda
Quoted 4 lines

When I look at patches 2 and 3, I must say I dislike the fact that in one case (svn), silencing is handled in pkg-download.mk when defining the SVN variable, while in the other case (git), it's handled in the git-specific helper script.

Quoted 7 lines

I would like to do the same for git but it does not work because:
git -q clone <url>
does not work, but
git clone -q <url>
works, so adding the "-q" in the script is the only option.

Do you have any better idea?

Yes: handle the svn case in the download helper as well. This way, we're consistent between svn and git. And maybe wget should be handled this way as well.

Yann can comment on this on whether my proposal is fine for him.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com