Skip to content

proc: deuglify task_state()

Oleg Nesterov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4proc: task_state: read cred->group_info outside of task_lock()fs/proc/array.c+1 -20 replies
2/4proc: task_state: deuglify the max_fds calculationfs/proc/array.c+11 -120 replies
3/4proc: task_state: move the main seq_printf() outside of rcu_read_lock()fs/proc/array.c+6 -61 reply
4/4proc: task_state: ptrace_parent() doesn't need pid_alive() checkfs/proc/array.c+6 -70 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPeter Zijlstra (Intel)Paul E. McKenneyEric W. Biederman
SeriesA-b R-b
1/4
2/4
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/4] proc: deuglify task_state()

Hello.

I tried to optimize the usage of tasklist_lock in exit_notify() paths but found the bug which should be fixed first: the EXIT_DEAD setting in reparent_leader() can break the task_ppid_nr_ns()-like code and ptrace_parent().

I am still thinking about the "right" fix, but whatever we do we need to cleanup these users, probably before the fix.

One particular user is task_state(), but it also asks for other off- topic cleanups which I believe make sense anyway, lets do this first.

Oleg.

 fs/proc/array.c |   47 ++++++++++++++++++++++-------------------------
 1 files changed, 22 insertions(+), 25 deletions(-)