Skip to content

ASoC: twl4030: support routine to external VOICE source.

NeilBrown alsa-devel linux-devicetree lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ASoC: twl4030: don't report EBUSY if no change requested.sound/soc/codecs/twl4030.c+6 -05 replies
2/3ASoC: twl4030: allow voice port to be connected externally.Documentation/devicetree/bindings/mfd/twl4030-audio.txt include/linux/i2c/twl.h sound/soc/codecs/twl4030.c+42 -24 replies
3/3ASoC: twl4030: enable routing audio to 'voice' interface.sound/soc/codecs/twl4030.c+44 -143 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] ASoC: twl4030: support routine to external VOICE source.

The 'voice' port of the twl4030 on my board is connected to a GSM modem, not to the CPU. As such it is not visible to ASLA and normal approaches to configuring the interface (as one end of a DAI) don't apply.

I need a way to tell the twl4030 that the connected device will be master of 'clk' and 'FRM', and whether they are inverted. Using device tree seems the correct approach - I am describing the properties of the hardware attached the 'voice' port.

Using magic numbers from include/sound/soc-dai.h almost certainly is not the right way to represent this information, but it isn't clear to me what a good way would be.

So the current patch uses magic numbers as a proof of concept, and I'm asking if there is any establish precedent, or any suggestions on how to record in device tree the 'master' and 'polarity' of CLK and FRM signals for an external device.
[I currently use (SND_SOC_DAIFMT_IB_NF | SND_SOC_DAIFMT_CBS_CFS)]

This is in the second patch. The first silences a pointless warning (when it is pointless) and the last allowed the voice linked to be turned on or off via ALSA controls.

If the first and last can be applied without finalizing the device-tree part yet, that would be great.

Thanks,
NeilBrown

---

NeilBrown (3):
ASoC: twl4030: don't report EBUSY if no change requested.
ASoC: twl4030: allow voice port to be connected externally.
ASoC: twl4030: enable routing audio to 'voice' interface.

 .../devicetree/bindings/mfd/twl4030-audio.txt      |    7 ++
 include/linux/i2c/twl.h                            |    3 +
 sound/soc/codecs/twl4030.c                         |   78 ++++++++++++++++++--
 3 files changed, 82 insertions(+), 6 deletions(-)

--
Signature

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html