Skip to content

sunvnet: edge-case/race-conditions bug fixes

Sowmini Varadhan netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3sunvnet: Fix race between vnet_start_xmit() and vnet_ack()drivers/net/ethernet/sun/sunvnet.c+6 -40 replies
2/3sunvnet: vnet_ack() should check if !start_cons to send a missed triggerdrivers/net/ethernet/sun/sunvnet.c+1 -10 replies
3/3sunvnet: Add missing rcu_read_unlock() in vnet_start_xmitdrivers/net/ethernet/sun/sunvnet.c+3 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3 net-next] sunvnet: edge-case/race-conditions bug fixes

This patch series contains fixes for race-conditions in sunvnet, that can encountered when there is a difference in latency between producer and consumer.

Patch 1 addresses a case when the STOPPED LDC ack from a peer is processed before vnet_start_xmit can finish updating the dr->prod state.

Patch 2 fixes the edge-case when outgoing data and incoming stopped-ack cross each other in flight.

Patch 3 adds a missing rcu_read_unlock(), found by code-inspection.

Sowmini Varadhan (3):
Fix race between vnet_start_xmit() and vnet_ack() vnet_ack() should check if !start_cons to send a missed trigger Add missing rcu_read_unlock() in vnet_start_xmit

 drivers/net/ethernet/sun/sunvnet.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)
Signature · 1 line
1.8.4.2