rt-tests: patches rename & versoin bump & support of non-NPTL tools
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 of 4 patches 0 repliesNew
1 of 4 patches is in this archive. The cover letter announces 4.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 4/4 | rt-tests: allow building subset of tests with non-NPTL toolchains | +0 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Buildroot] [PATCH 0/4] rt-tests: patches rename & versoin bump & support of non-NPTL tools
Dear Alexey Brodkin,
Quoted 6 lines · Alexey Brodkin
Quoted 5 lines
* You should never resend a new version of just one patch. Always send the complete series again, even if only one patch has changed. I was mistaken when looking at patchwork, and originally only applied the patch removing the NPTL dependency, because it was available standalone, outside of any series.
Quoted 6 lines
Indeed my bad, I was not sure if I may re-send only 1 patch so I asked if that's ok but never got an answer here
http://permalink.gmane.org/gmane.comp.lib.uclibc.buildroot/99171Nevertheless I understand that that's my fault and I'll try to not do such silly things in the future, so thanks for this comment.
No problem! Everybody learns progressively how to do things :)
Quoted 6 lines
Quoted 2 lines
* You should use 'git format-patch -M' to enable rename detection. It would have made patch 1 a lot smaller, and easier to review.
Hm, I didn't know about this actually.
I did "git mv" and believed that there's nothing else I may do to simplify rename changes. Will do it this way next time.
I must confess that I don't actually don't know precisely how git encodes renames. But basically, my understanding is that even if you do "git mv", "git format-patch" will encode a rename as a complete removal
+ a complete addition, because that's the only way, in the traditional patch format, to express a rename. However, by passing -M to git format-patch, you tell git that it can generate a git patch, making the assumption that it's git that will be used to apply the patch, and not just the basic "patch" tool. In this case, it can encode the rename in a smarter way.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com