error cleanups in lock_ref_sha1_basic
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 16 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | error: save and restore errnousage.c | +3 | 5 replies | |
| 2/4 | lock_ref_sha1_basic: simplify errno handlingrefs.c | +1 | 2 replies | |
| 3/4 | lock_ref_sha1_basic: simplify error code pathrefs.c | +4 | 8 replies | |
| 4/4 | lock_ref_sha1_basic: do not die on locking errorsrefs.c | +9 | 1 reply |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Jonathan Nieder | Stefan Beller |
|---|---|---|
| 1/4 | R-b | R-b |
| 2/4 | R-b | |
| 3/4 | R-b | |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4] error cleanups in lock_ref_sha1_basic
Quoted 7 lines · Stefan Beller
From: Ronnie Sahlberg <[email protected]>
Change
lock_ref_sha1_basicto return an error instead of dying, when we fail to lock a file during a transaction. This function is only called fromtransaction_commit()and it knows how to handle these failures.
Quoted 5 lines
[sb: This was part of a larger patch series, cherry-picked to master]
Signed-off-by Ronnie Sahlberg <[email protected]>Signed-off-by Jonathan Nieder <[email protected]>Signed-off-by Stefan Beller <[email protected]>
I think this is a good thing to do. I independently wrote the same patch recently, along with some other cleanups. Here's the series I ended up with (I added Ronnie as the author of the final one, which replaces this; even though my discovery was independent, he wrote it first :) ).
[1/4]: error: save and restore errno
[2/4]: lock_ref_sha1_basic: simplify errno handling [3/4]: lock_ref_sha1_basic: simplify error code path [4/4]: lock_ref_sha1_basic: do not die on locking errors
-Peff