(node.js) fix npm CC, other npm tweaks
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 patch 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | Fix npm module cross compilation, use up-to-date npm and install modules globally | +0 | 1 reply | |
| 1/1 | Fix npm module cross compilation, use up-to-date npm and install modules globally | +0 | 0 replies | |
| 1/1 | Fix npm module cross compilation, use up-to-date npm and install modules globally | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Buildroot] [PATCH 0/1] (node.js) fix npm CC, other npm tweaks
Dear Michael Wei,
Quoted 11 lines · Michael Wei
For some reason, node modules with native code (compiled using tools like gyp) were not being cross compiled properly without the --target_arch switch.
In addition, the version of npm that is provided with the version of node uses is old, and has some bugs like race conditions in dependency resolution which can break builds, so this patch also updates the host npm before install.
Finally, node modules are now installed globally. This allows modules to install things such as command line utilities.
Thanks for this contribution. Could you include this detailed explanation into the commit log of the patch?
Currently, the detailed explanation is only part of the cover letter, which will not become part of the Buildroot commit history. It would therefore be better to have the same explanation inside the patch itself, so that it will become part of the Buildroot commit history.
Thanks a lot,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com