Skip to content

ATM: HE: Cleanup coding style

Greg KH kernelnewbies 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest1 of 2 patches 0 repliesNew
  2. v11 patch 0 repliesSuperseded

1 of 2 patches is in this archive. The cover letter announces 2.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
2/2ATM: HE: Cleanup coding style (struct braces)+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] ATM: HE: Cleanup coding style
Quoted 9 lines · Jonathan Jin

At Greg KH's advice, I've revised my previous formatting patch by splicing it into two separate patches in the same sequence. If I could get additional feedback, I'd very much appreciate it.

This patch sequence cleans up the following coding style issues that are detected by checkpatch:
ERROR: trailing whitespace
ERROR: open brace '{' following struct go on the same line

Quoted 6 lines

Jonathan Jin (2):
ATM: HE: Cleanup coding style (whitespace)
ATM: HE: Cleanup coding style (struct braces)

 drivers/atm/he.h | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

Looks good, just the one nit about the leading spaces in the changelog entry.

But note, some maintainers don't care about patches like this, so if they are ignored, be prepared. If they don't get picked up in a month or so, try a subsystem that wants these types of patches, like the staging tree.

thanks,

greg k-h