Skip to content

blackfin: bf533-stamp: add linux/delay.h

Oleg Nesterov linux-mm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1blackfin: bf533-stamp: add linux/delay.harch/blackfin/mach-bf533/boards/stamp.c+1 -01 reply

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchMike Frysinger
1/1A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/1] blackfin: bf533-stamp: add linux/delay.h
Quoted 10 lines · kbuild test robot
tree:   git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   53262d12d1658669029ab39a63e3d314108abe66
commit: a1fd3e24d8a484b3265a6d485202afe093c058f3 percpu_rw_semaphore: reimplement to not block the readers unnecessarily
date:   2 years ago
config: blackfin-allyesconfig (attached as .config)

reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
git checkout a1fd3e24d8a484b3265a6d485202afe093c058f3

Quoted 8 lines
  # save the attached .config to linux build tree
  make.cross ARCH=blackfin

All error/warnings:

   arch/blackfin/mach-bf533/boards/stamp.c: In function 'net2272_init':
Quoted 1 line
Quoted 1 line

arch/blackfin/mach-bf533/boards/stamp.c:834:2: error: implicit declaration of function 'mdelay' [-Werror=implicit-function-declaration]

cc1: some warnings being treated as errors

That commit removed linux/delay.h from percpu-rwsem.h. But stamp.c obviously should not rely on percpu-rwsem.h, and in fact fs.h includes it by mistake (this needs another patch).

I think mach-bf533/boards/stamp.c needs the trivial fix.

Quoted 31 lines

vim +/mdelay +834 arch/blackfin/mach-bf533/boards/stamp.c

9be8631b Mike Frysinger 2011-05-04  818  		gpio_free(GPIO_PF0);
9be8631b Mike Frysinger 2011-05-04  819  		return ret;
9be8631b Mike Frysinger 2011-05-04  820  	}
9be8631b Mike Frysinger 2011-05-04  821
9be8631b Mike Frysinger 2011-05-04  822  	ret = gpio_request(GPIO_PF11, "net2272");
9be8631b Mike Frysinger 2011-05-04  823  	if (ret) {
9be8631b Mike Frysinger 2011-05-04  824  		gpio_free(GPIO_PF0);
9be8631b Mike Frysinger 2011-05-04  825  		gpio_free(GPIO_PF1);
9be8631b Mike Frysinger 2011-05-04  826  		return ret;
9be8631b Mike Frysinger 2011-05-04  827  	}
9be8631b Mike Frysinger 2011-05-04  828
9be8631b Mike Frysinger 2011-05-04  829  	gpio_direction_output(GPIO_PF0, 0);
9be8631b Mike Frysinger 2011-05-04  830  	gpio_direction_output(GPIO_PF1, 1);
9be8631b Mike Frysinger 2011-05-04  831
9be8631b Mike Frysinger 2011-05-04  832  	/* Reset the USB chip */
9be8631b Mike Frysinger 2011-05-04  833  	gpio_direction_output(GPIO_PF11, 0);
9be8631b Mike Frysinger 2011-05-04 @834  	mdelay(2);
9be8631b Mike Frysinger 2011-05-04  835  	gpio_set_value(GPIO_PF11, 1);
9be8631b Mike Frysinger 2011-05-04  836  #endif
9be8631b Mike Frysinger 2011-05-04  837
9be8631b Mike Frysinger 2011-05-04  838  	return 0;
9be8631b Mike Frysinger 2011-05-04  839  }
9be8631b Mike Frysinger 2011-05-04  840
1394f032 Bryan Wu       2007-05-06  841  static int __init stamp_init(void)
1394f032 Bryan Wu       2007-05-06  842  {

:::::: The code at line 834 was first introduced by commit
:::::: 9be8631b8a7d11fa6d206fcf0a7a2005ed39f41b Blackfin: net2272: move pin setup to boards files

Quoted 6 lines

:::::: TO: Mike Frysinger <[email protected]>
:::::: CC: Mike Frysinger <[email protected]>

---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

Read the cover letter in its thread