Skip to content

Fix repeated USB scans problems

Marek Vasut u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/2] Fix repeated USB scans problems
Quoted 14 lines · Stephen Warren
Quoted 13 lines · Hans de Goede

Hi Marek & Stephen,

As discussed before we've a problem where our standard bootcmds sometimes scan usb more then once, causing a large boot delay.

Marek, as discussed with you before, this patch-set tackles this differently then previous sets, by simply making "usb start" a oneshot command (atleast until "usb stop" is called).

Stephen the second patch then modifies config_distro_bootcmd.h to simply call "usb start" unconditionally, since calling it repeatedly now can be done without side-effects.

Quoted 6 lines
Quoted 3 lines

Assuming you both like these patches, that leaves the question of how to merge them, they can be merged individually each through your own trees, or one of you can pick up both of them, I'll leave that to you.

Users will have to get used to running "usb reset" rather than "usb start", but I guess that's fine.

Hi!

So why do we not have "usb reset" only, why can we not discard the "usb start" altogether?

Quoted 1 line

Should we rename "usb reset" to "usb restart"?

No, let's not mess with the UI any more than we already did.

Quoted 4 lines

Either way, the series,

Will you do something similar for SCSI?

Best regards,
Marek Vasut