USB: host: Atmel OHCI and EHCI drivers improvements
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest6 patches 0 repliesNew
- v5 posting 2/20 of 6 patches 0 repliesSuperseded
- v66 patches 0 repliesSuperseded
Earlier versions · 6
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 posting 1/2 | 6 patches | 0 replies | Superseded | |
| v3 posting 2/2 | 0 of 5 patches | 0 replies | Superseded | |
| v4 | 6 patches | 0 replies | Superseded | |
| v3 posting 1/2 | 5 patches | 0 replies | Superseded | |
| v2 | 2 patches | 0 replies | Superseded | |
| v1 | 1 patch | 0 replies | Superseded |
Changes in v7 from the cover letter
* Collected Acked-by tags
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | USB: host: ehci-atmel: Add suspend/resume supportdrivers/ | +31 | 0 replies | |
| 2/6 | USB: host: ohci-at91: Use struct dev_pm_ops instead of struct platform_driverdrivers/ | +10 | 0 replies | |
| 3/6 | USB: host: ehci-atmel: Move global variables to private structdrivers/ | +50 | 0 replies | |
| 4/6 | USB: host: ohci-at91: Move global variables to private structdrivers/ | +51 | 0 replies | |
| 5/6 | USB: host: ohci-at91: usb_hcd_at91_probe(), remove useless stack initialisationdrivers/ | +1 | 0 replies | |
| 6/6 | USB: host: ohci-at91: Fix wake-up supportdrivers/ | +19 | 0 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Boris Brezillon | Alan Stern | Nicolas Ferre | Alexandre Belloni |
|---|---|---|---|---|
| 1/6 | A-b | A-b | A-b | A-b |
| 2/6 | A-b | A-b | A-b | |
| 3/6 | A-b | A-b | A-b | |
| 4/6 | A-b | A-b | A-b | |
| 5/6 | A-b | A-b | A-b | |
| 6/6 | A-b | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCHv7 0/6] USB: host: Atmel OHCI and EHCI drivers improvements
USB: host: Atmel OHCI and EHCI drivers improvements
Suspend/resume support for EHCI.
struct dev_pm_ops for OHCI.
Removed global variables from both.
Fixed OHCI wake up support for STANDBY(wake-up enabled) and MEM(wake-up disabled) sleep targets.
Changes since v6:
* Collected Acked-by tags
Changes since v5:
* Don't overwrite device wakeup flag with device_init_wakeup(), now using a private wakeup bool instead.
Changes since v4:
* Re-add at91_suspend_entering_slow_clock() to OHCI, we can't naively remove this one, this device needs to be continuously clocked to provide wake up support.
The removal of at91_suspend_entering_slow_clock() actually lighted up an issue on wake up support, which is now fixed.
Changes since v3:
* Using struct dev_pm_ops instead of static struct platform_driver resume and suspend bindings for both EHCI and OHCI
* Fixed inconsistency in patch subjects, _ intead of - for file names
* Patch cleaning with the help of checkpatch.pl, fixed lines over 80 characters
Changes since v2:
* Added patchs from an other submission, because this series depended on this one
* EHCI: Move global variables to private struct
* OHCI: Move global variables to private struct
* Using ohci->priv and ehci->priv instead of hcd->hcd_priv, which were not the right way to do that
Changes since v1:
* Don't use at91_suspend_entering_slow_clock() on EHCI, we are trying to get read of this of this function
* Removed at91_suspend_entering_slow_clock() from OHCI
Sylvain Rochet (6):
USB: host: ehci-atmel: Add suspend/resume support
USB: host: ohci-at91: Use struct dev_pm_ops instead of struct
platform_driver
USB: host: ehci-atmel: Move global variables to private struct
USB: host: ohci-at91: Move global variables to private struct
USB: host: ohci-at91: usb_hcd_at91_probe(), remove useless stack
initialisation
USB: host: ohci-at91: Fix wake-up support
drivers/usb/host/ehci-atmel.c | 102 +++++++++++++++++++++++++--------- drivers/usb/host/ohci-at91.c | 126 ++++++++++++++++++++++++++---------------- 2 files changed, 154 insertions(+), 74 deletions(-)
Signature · 1 line
2.1.4