Skip to content

Overhaul the audit filename handling

Paul Moore linux-audit linux-fsdevel lkml 2 versions – In review

Get series with b4
b4 am 20150122045303.1347.98054.stgit@localhost

Versions newest first · linked by author and title

  1. v2 Latest5 patches 21 repliesIn review
  2. v15 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5fs: rework getname_kernel to handle up to PATH_MAX sized filenamesfs/namei.c+20 -142 replies
2/5fs: create proper filename objects using getname_kernel()fs/exec.c fs/namei.c fs/open.c+81 -211 reply
3/5audit: enable filename recording via getname_kernel()fs/namei.c kernel/auditsc.c+4 -370 replies
4/5audit: fix filename matching in __audit_inode() and __audit_inode_child()kernel/auditsc.c+25 -91 reply
5/5audit: replace getname()/putname() hacks with reference countersfs/namei.c include/linux/audit.h include/linux/fs.h +2 more+29 -1342 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchRichard Guy BriggsGuenter Roeck
SeriesT-b
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] Overhaul the audit filename handling

This patchset has some important changes from the previous revision, namely a fix from Al Viro (included in 2/5) that resolves a boot panic on some systems as well as some smaller, less noteworthy fixes found in the linux-next announcement thread from January 20th (refcount bump in __audit_reusename() and a inode type in __audit_inode()).

This patchset still needs some additional testing to verify that the audit code still functions properly (the minor fixes mentioned above) and there is an additional patch from Al that should be included as well, but I wanted to post this and push the series to the audit next branch quickly since a number of folks were affected by the boot panic.

---

Paul Moore (5):
fs: rework getname_kernel to handle up to PATH_MAX sized filenames
fs: create proper filename objects using getname_kernel()
audit: enable filename recording via getname_kernel()
audit: fix filename matching in __audit_inode() and __audit_inode_child()
audit: replace getname()/putname() hacks with reference counters

 fs/exec.c             |   11 +++
 fs/namei.c            |  144 ++++++++++++++++++++++++++++-------------
 fs/open.c             |   11 +++
 include/linux/audit.h |    3 -
 include/linux/fs.h    |    9 +--
 kernel/audit.h        |   17 +----
 kernel/auditsc.c      |  171 ++++++++++---------------------------------------
 7 files changed, 155 insertions(+), 211 deletions(-)