Skip to content

USB: gadget: atmel_usba_udc: Driver improvements

Boris Brezillon linux-arm-kernel 1 version New

Get series with b4
b4 am 20150121214629.5b1e3e30@bbrezillon

Versions newest first

  1. v5 Latest1 of 4 patches 0 repliesNew

1 of 4 patches is in this archive. The cover letter announces 4.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
4/4USB: gadget: atmel_usba_udc: Add suspend/resume with wakeup support+0 -00 replies

Reviews trailers per patch

The patch has no Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBoris Brezillon
SeriesA-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCHv5 0/4] USB: gadget: atmel_usba_udc: Driver improvements

Hi Sylvain,

Quoted 4 lines · On Wed, 21 Jan 2015 20:31:10 +0100 Sylvain Rochet…

Start clocks on rising edge of the Vbus signal, stop clocks on falling edge of the Vbus signal.

Add suspend/resume with wakeup support.

Apart from the minor comment I made on patch 4, you can add my:

Acked-by Boris Brezillon <[email protected]>

to the whole series.

Thanks for your patience.

Best Regards,

Boris

Quoted 37 lines

Changes since v4:
* Now using IRQ_NOAUTOEN flag to remove the unused check for

    udc->driver is not NULL in the Vbus IRQ.

* Reworked the start/stop of clocks on Vbus edges to prepare for suspend/resume support, factorised start and stop procedures
* New patch, suspend/resume for USBA with wakeup support

Changes since v3:
* Added stable tag for the first patch
* As suggested, removed the unused check for udc->driver is not NULL in

    Vbus IRQ by requesting IRQ after udc->driver is set and by releasing
    IRQ before udc->driver is cleared

* Rebased the core patch of this series against the just explained changes

Changes since v2:
* Use spin_lock_irqsave/unlock_irqrestore instead of spin_lock/unlock in threaded interrupt because we are not in irq context anymore
* Removed useless and probably harmful IRQF_NO_SUSPEND from devm_request_threaded_irq() flags

Changes since v1:
* Using a threaded irq and mutex instead of spinclock as suggested
* Moved a silently fixed bug in a separate patch (1/2)

Sylvain Rochet (4):
USB: gadget: atmel_usba_udc: Fixed vbus_prev initial state
USB: gadget: atmel_usba_udc: Request an auto disabled Vbus signal IRQ
instead of an auto enabled IRQ request followed by IRQ disable
USB: gadget: atmel_usba_udc: Start clocks on rising edge of the Vbus
signal, stop clocks on falling edge of the Vbus signal
USB: gadget: atmel_usba_udc: Add suspend/resume with wakeup support

 drivers/usb/gadget/udc/atmel_usba_udc.c | 214 ++++++++++++++++++++++++--------
 drivers/usb/gadget/udc/atmel_usba_udc.h |   4 +
 2 files changed, 165 insertions(+), 53 deletions(-)
Signature · 3 lines
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Read the cover letter in its thread