Skip to content

perf: Have perf become tracefs aware

Steven Rostedt lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 2 repliesIn review
  2. v26 patches 5 repliesSuperseded
  3. v15 patches 19 repliesSuperseded

Changes in v3 from the cover letter

o Fixed directory name to /sys/kernel/tracing as per Namhyung Kim's comment

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6perf: Do not check debugfs MAGIC for tracing filestools/lib/api/fs/debugfs.c tools/lib/api/fs/debugfs.h tools/perf/util/parse-events.c+14 -340 replies
2/6tools lib fs: Add helper to find mounted file systemstools/lib/api/Makefile tools/lib/api/fs/debugfs.c tools/lib/api/fs/debugfs.h +2 more+94 -540 replies
3/6tools lib api fs: Add tracefs mount helper functionstools/lib/api/Makefile tools/lib/api/fs/tracefs.c tools/lib/api/fs/tracefs.h+92 -00 replies
4/6tools lib api fs: Add DEBUGFS_DEFAULT_PATH macrotools/lib/api/fs/debugfs.c+7 -30 replies
5/6tools lib api fs: Add {tracefs,debugfs}_configured() functionstools/lib/api/fs/debugfs.c tools/lib/api/fs/debugfs.h tools/lib/api/fs/findfs.h +2 more+20 -00 replies
6/6perf: Make perf aware of tracefstools/perf/tests/open-syscall-all-cpus.c tools/perf/tests/open-syscall.c tools/perf/tests/parse-events.c +6 more+91 -250 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH 0/6 v3] perf: Have perf become tracefs aware

As I'm trying to move the tracing directory from debugfs, perf needs to be aware of this as system admins will now be able to mount the tracing directory without needing to mount debugfs. This patch series addresses this and makes perf aware of tracefs.

You can also get this series from my repo as stated below.

Changes since v2:

o Fixed directory name to /sys/kernel/tracing as per Namhyung Kim's comment

Changes since v1:

o Added a patch to nuke the debugfs_valid_mountpoint.
Well, it doesn't totally nuke it. It still uses that function (static though) to test if the "default" debugfs locations may already contain a debugfs file system. I also have tracefs do the same.

o Fixed setting of debugfs_found and tracefs_found

o Moved STR macro and PATH_MAX macros from debugfs.h to findfs.h

o Changed debugfs_configured() and tracefs_configured() to use find_mountpoint() to see if they are configured.

Internal SHA1: 51c77ca617b3a592e0d658127b5c61dd12225db1

Steven Rostedt (Red Hat) (6):
perf: Do not check debugfs MAGIC for tracing files tools lib fs: Add helper to find mounted file systems tools lib api fs: Add tracefs mount helper functions tools lib api fs: Add DEBUGFS_DEFAULT_PATH macro tools lib api fs: Add {tracefs,debugfs}_configured() functions
perf: Make perf aware of tracefs

----

 tools/lib/api/Makefile                   |  4 ++
 tools/lib/api/fs/debugfs.c               | 69 +++++++++-------------------
 tools/lib/api/fs/debugfs.h               | 13 +-----
 tools/lib/api/fs/findfs.c                | 63 ++++++++++++++++++++++++++
 tools/lib/api/fs/findfs.h                | 23 ++++++++++
 tools/lib/api/fs/tracefs.c               | 78 ++++++++++++++++++++++++++++++++
 tools/lib/api/fs/tracefs.h               | 21 +++++++++
 tools/perf/tests/open-syscall-all-cpus.c |  7 ++-
 tools/perf/tests/open-syscall.c          |  7 ++-
 tools/perf/tests/parse-events.c          | 13 +++++-
 tools/perf/util/cache.h                  |  1 +
 tools/perf/util/evlist.c                 |  1 -
 tools/perf/util/parse-events.c           | 19 --------
 tools/perf/util/parse-events.h           |  2 +-
 tools/perf/util/probe-event.c            | 24 ++++++----
 tools/perf/util/util.c                   | 60 +++++++++++++++++++-----
 tools/perf/util/util.h                   |  1 +
 17 files changed, 304 insertions(+), 102 deletions(-)