Skip to content

RFC samba4: allow build of libsmbclient only

Thomas Petazzoni buildroot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Buildroot] [RFC 0/3] samba4: allow build of libsmbclient only

Hello,

Quoted 13 lines · zooey at hirschkaefer.de

this set of patches is a first draft of allowing a separate build of samba4's libsmbclient. Most of our devices don't need all of the other samba servers and tools, so it seems a bit of a waste having to build them all.

The first patch contains the naive attempt at implementing the separation.

However, it seems that samba4's build system gets confused when not all targets have been built, as it tries to install manpages along with libsmbclient which haven't been generated during the build phase. Patch 2 works around the problem by deactivating installation of manpages in general, but as that is hardly acceptable, I wonder if anyone here has a better idea?

Quoted 8 lines

Patch 3 appies --disable-rpath-private-install in order to work around another build problem, which is apparently caused by libsmbclient.inst.so (and additional install libraries) to not have been created during the build phase. Again, the solution proposed in the patch isn't a good one, as it basically means that samba4's private libraries are not being built with RPATH set, which is bound to cause problems at runtime (they won't be found by the runtime loader). As with patch 2, I'd be grateful for any hints at better solutions.

Thanks for those patches. However, as you point out in your cover letter, those patches are not really acceptable as is. Moreover, those are really "feature patches", and we generally try to avoid them if possible. Could you instead work with the upstream Samba developers a solution to build only smbclient, and see where that goes?

Thanks a lot,

Thomas Petazzoni

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com