clean up push config callbacks
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 14 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | git_push_config: drop cargo-culted wt_status pointerbuiltin/ | +1 | 0 replies | |
| 2/2 | builtin/push.c: make push_default a static variablebuiltin/ cache.h config.c +1 more | +33 | 10 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] clean up push config callbacks
Quoted 11 lines · Jeff King
But here you are adding to
git_default_push_config, which is in another file.I'm trying to figure out why
git_default_push_configexists at all. The major difference fromgit_push_configis that the "default" variant will get loaded for _all_ commands, not just "push". So if it affected variables that were used by other commands, it would be needed. But all it sets ispush_default, which seems to be specific tobuiltin/push.c.So I suspect it can be removed entirely, and folded into
git_config_push. But that's outside the scope of your patch.
Here's that cleanup, plus another one I noticed while doing it.
[1/2]: git_push_config: drop cargo-culted wt_status pointer [2/2]: builtin/push.c: make push_default a static variable
-Peff