Skip to content

Some kernel/time cleanups

Peter Zijlstra linux-acpi linux-pm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest35 patches 40 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/35ACPI/acpi_pad: Remove the local apic nonsensedrivers/acpi/acpi_pad.c+5 -212 replies
2/35clockevents: Remove CONFIG_GENERIC_CLOCKEVENTS_BUILDinclude/linux/clockchips.h kernel/time/Kconfig kernel/time/Makefile +2 more+7 -210 replies
3/35tick: Cleanup internal header fileskernel/time/clocksource.c kernel/time/jiffies.c kernel/time/ntp.c +2 more+9 -90 replies
4/35tick: Cleanup internal header filekernel/time/tick-internal.h+49 -960 replies
5/35tick: Move core only declarations and functions to coreinclude/linux/clockchips.h include/linux/tick.h kernel/time/clocksource.c +5 more+110 -1270 replies
6/35clockevents: Remove extra local_irq_save in clockevents_exchange_device()kernel/time/clockevents.c+2 -50 replies
7/35clockevents: Make suspend/resume calls explicitarch/x86/xen/suspend.c include/linux/clockchips.h include/linux/tick.h +4 more+32 -251 reply
8/35tick: Make tick_resume_broadcast_oneshot statickernel/time/tick-broadcast.c kernel/time/tick-internal.h+4 -50 replies
9/35tick/xen: Provide and use tick_resume_local()arch/x86/xen/suspend.c include/linux/tick.h kernel/time/tick-broadcast.c +2 more+49 -221 reply
10/35clockevents: Make tick handover explicitinclude/linux/clockchips.h include/linux/tick.h kernel/cpu.c +4 more+11 -130 replies
11/35clockevents: Cleanup dead cpu explicitelyinclude/linux/clockchips.h include/linux/tick.h kernel/cpu.c +5 more+62 -510 replies
12/35clockevents: Provide explicit broadcast control functioninclude/linux/tick.h kernel/time/clockevents.c kernel/time/tick-broadcast.c +1 more+57 -382 replies
13/35x86, amd_idle: Use explicit broadcast control functionsarch/x86/kernel/process.c+3 -60 replies
14/35ACPI / PAD: Use explicit broadcast control functiondrivers/acpi/acpi_pad.c+2 -30 replies
15/35ACPI/ processor_idle: Use explicit broadcast controll functiondrivers/acpi/processor_idle.c+5 -60 replies
16/35cpuidle: Use explicit broadcast control functiondrivers/cpuidle/driver.c+12 -131 reply
17/35intel_idle: Use explicit broadcast control functiondrivers/idle/intel_idle.c+6 -70 replies
18/35ARM: OMAP: Use explicit broadcast control functionarch/arm/mach-omap2/cpuidle44xx.c+2 -31 reply
19/35clockevents: Remove the broadcast control leftoversinclude/linux/clockchips.h kernel/time/clockevents.c+0 -130 replies
20/35clockevents: Provide explicit broadcast oneshot control functioninclude/linux/tick.h kernel/time/clockevents.c kernel/time/tick-broadcast.c +1 more+39 -141 reply
21/35x86, amd_idle: Use explicit broadcast oneshot control functionsarch/x86/kernel/process.c+2 -20 replies
22/35ACPI / PAD: Use explicit broadcast oneshot control functiondrivers/acpi/acpi_pad.c+2 -40 replies
23/35ACPI/ processor_idle: Use explicit broadcast oneshot controll functiondrivers/acpi/processor_idle.c+4 -50 replies
24/35intel_idle: Use explicit broadcast oneshot control functiondrivers/idle/intel_idle.c+2 -20 replies
25/35ARM: OMAP: Use explicit broadcast oneshot control functionarch/arm/mach-omap2/cpuidle44xx.c+2 -31 reply
26/35ARM: tegra: Use explicit broadcast oneshot control functionarch/arm/mach-tegra/cpuidle-tegra114.c arch/arm/mach-tegra/cpuidle-tegra20.c arch/arm/mach-tegra/cpuidle-tegra30.c+13 -130 replies
27/35sched/idle: Use explicit broadcast oneshot control functionkernel/sched/idle.c+2 -32 replies
28/35clockevents: Remove the broadcast oneshot control leftoversinclude/linux/clockchips.h kernel/time/clockevents.c+0 -390 replies
29/35tick/timekeeping: Make PM_SLEEP related code conditionalinclude/linux/clockchips.h include/linux/clocksource.h kernel/time/clockevents.c +6 more+21 -140 replies
30/35timekeeping: Get rid of stale commentkernel/time/timekeeping.c+0 -40 replies
31/35clockevents: Consolidate tick_shutdown()kernel/time/clockevents.c kernel/time/tick-broadcast.c kernel/time/tick-common.c +1 more+15 -130 replies
32/35clockevents: Fix cpu down race for hrtimer based broadcastinginclude/linux/tick.h kernel/cpu.c kernel/time/clockevents.c +3 more+63 -5419 replies
33/35tick: Make hrtimer broadcasting opt-inarch/arm/kernel/smp.c arch/arm64/Kconfig arch/arm64/kernel/smp.c +10 more+41 -352 replies
34/35tick: Provide tick_suspend_local()include/linux/tick.h kernel/time/tick-common.c+18 -36 replies
35/35arm: bl_switcher: Kill tick suspend hackeryarch/arm/common/bL_switcher.c include/linux/clockchips.h include/linux/tick.h +2 more+19 -360 replies

Reviews trailers per patch

5 of 35 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDavid VrabelRafael J. WysockiPreeti U MurthyLorenzo PieralisiDaniel LezcanoTony LindgrenNicolas Pitre
SeriesA-b A-b
1/35A-b
2/35
3/35
4/35
5/35
6/35
7/35
8/35
9/35A-b
10/35
11/35
12/35A-b T-b
13/35
14/35
15/35
16/35A-b
17/35
18/35T-b
19/35
20/35T-b
21/35
22/35
23/35
24/35
25/35T-b
26/35
27/35
28/35
29/35
30/35
31/35
32/35
33/35R-b R-b
34/35
35/35

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v1 thread

Cover letter [PATCH 00/35] Some kernel/time cleanups

Hi,

While working with Rafael on the suspend to idle machinery Thomas made these cleanups; since one might as well clean code up while you've done the work of thinking through it again.

As it stands there's very little overlap between Rafael's series and this one aside from a few trivial fixups. So we'll merge them seperately.

---
 arch/arm/common/bL_switcher.c          |  16 +--
 arch/arm/kernel/smp.c                  |   2 +-
 arch/arm/mach-omap2/cpuidle44xx.c      |  10 +-
 arch/arm/mach-tegra/cpuidle-tegra114.c |   6 +-
 arch/arm/mach-tegra/cpuidle-tegra20.c  |  10 +-
 arch/arm/mach-tegra/cpuidle-tegra30.c  |  10 +-
 arch/arm64/Kconfig                     |   1 +
 arch/arm64/kernel/smp.c                |   1 +
 arch/arm64/kernel/time.c               |   2 +-
 arch/mips/kernel/smp.c                 |   1 +
 arch/powerpc/Kconfig                   |   1 +
 arch/powerpc/kernel/smp.c              |   1 +
 arch/powerpc/kernel/time.c             |   2 +-
 arch/x86/kernel/process.c              |  13 +--
 arch/x86/xen/suspend.c                 |  11 +-
 drivers/acpi/acpi_pad.c                |  29 +----
 drivers/acpi/processor_idle.c          |  20 ++--
 drivers/cpuidle/driver.c               |  23 ++--
 drivers/idle/intel_idle.c              |  17 ++-
 include/linux/clockchips.h             |  65 +----------
 include/linux/clocksource.h            |   2 -
 include/linux/tick.h                   | 200 ++++++++++++++-------------------
 kernel/cpu.c                           |   4 +
 kernel/sched/idle.c                    |   5 +-
 kernel/time/Kconfig                    |  10 +-
 kernel/time/Makefile                   |  12 +-
 kernel/time/clockevents.c              |  95 +++++-----------
 kernel/time/clocksource.c              |   2 +
 kernel/time/hrtimer.c                  |   9 +-
 kernel/time/jiffies.c                  |   2 +-
 kernel/time/ntp.c                      |   1 -
 kernel/time/tick-broadcast.c           | 194 ++++++++++++++++++--------------
 kernel/time/tick-common.c              |  89 ++++++++++-----
 kernel/time/tick-internal.h            | 189 +++++++++++++------------------
 kernel/time/tick-sched.c               |   7 +-
 kernel/time/timekeeping.c              |  12 +-
 kernel/time/timekeeping.h              |  10 ++
 kernel/time/timer_list.c               |   2 +-
 38 files changed, 477 insertions(+), 609 deletions(-)