Skip to content

x86/fpu: minor cleanups

Oleg Nesterov lkml 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2x86/regsets: change xstateregs_get/set to use ->xsave.i387 rather than ->fxsavearch/x86/kernel/i387.c+9 -162 replies
2/2x86/fpu: factor out memset(xstate, 0) in fpu_finit() pathsarch/x86/include/asm/fpu-internal.h arch/x86/kernel/i387.c+2 -22 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRik van Riel
1/2R-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] x86/fpu: minor cleanups

add lkml/cc's.

Quoted 8 lines · Oleg Nesterov

Btw, why xstateregs_get/set() looks so confusing? The comment says "Copy the 48bytes defined by the software first into the xstate" but the code uses ->fxsave. Yes, this is the same memory, but still. I'll send the cosmetic cleanup.

Or fx_finit()... Again, memset(fx, 0, xstate_size) is correct but only because of the current layout. I think this needs a cleanup too.

Of course this is purely cosmetic, but still...

Oleg.