Skip to content

x86/cpu: kill eager_fpu_init_bp()

Oleg Nesterov lkml stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 1 patch 0 repliesNew

Patches in v1 No applies recorded yet

The patch the cover letter announces is not in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] x86/cpu: kill eager_fpu_init_bp()
Quoted 12 lines · Borislav Petkov
Quoted 10 lines · Oleg Nesterov

Hello.

This patch is "out of order" a bit, but since Borislav mentioned this during review...

And I was going to send the 2nd one (below), but it turns out that __init_refok is not discarded? So is there any way to do

	void __init init_function();
Quoted 7 lines
Quoted 7 lines
	void non_init_func()
	{
		if (can_only_be_true_before_free_initmem)
			init_function();
	}

and avoid the warning?

It turns out I _completely_ misunderstood __init_refok.

Quoted 2 lines

Actually, I was wondering if we could be even more radical and do the boot cpu-specific stuff only in the BSP boot path.

Yes, yes, agreed. This needs more changes, but imo this would be a nice cleanup.

Still. I think it makes sense to kill eager_fpu_init_bp() right now, this won'r complicate the mentioned cleanups.

On top of "x86/fpu: don't allocate fpu->state for swapper/0".

Oleg.

Read the cover letter in its thread