Skip to content

Allow twl4030_charger to find phy reliably.

NeilBrown linux-devicetree linux-pm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2usb: phy: Add interface to get phy give of device_node.drivers/usb/phy/phy.c include/linux/usb/phy.h+72 -270 replies
2/2twl4030_charger: find associated phy by more reliable means.Documentation/devicetree/bindings/power/twl-charger.txt Documentation/devicetree/bindings/usb/twlxxxx-usb.txt drivers/power/twl4030_charger.c+22 -122 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPavel MachekSebastian Reichel
1/2A-b
2/2A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Allow twl4030_charger to find phy reliably.

The twl4030_charger is physically paired with the twl4030 USB phy, so the drivers need to be able to reliably find each other.

twl4030_charger currently uses usb_get_phy(), which works if there is only one phy to choose from, but is not reliable in more complex configurations.

These patches add a new interface to allow a phy to be found given a device node, and then use that interface in twl4030_charger so that it finds its sibling in the devicetree, and gets the phy associated with that.

===

This is a resend with improved documentation. I'm hoping this can go in to the next merge window, though should it go through usb/phy or power???

Thanks,
NeilBrown

---

NeilBrown (2):
usb: phy: Add interface to get phy give of device_node.
twl4030_charger: find associated phy by more reliable means.

 .../devicetree/bindings/power/twl-charger.txt      |   10 ++
 .../devicetree/bindings/usb/twlxxxx-usb.txt        |    3 +
 drivers/power/twl4030_charger.c                    |   21 ++--
 drivers/usb/phy/phy.c                              |   97 ++++++++++++++------
 include/linux/usb/phy.h                            |    2 
 5 files changed, 94 insertions(+), 39 deletions(-)

--
Signature