Enhance twl4030_charger functionality. - V2
Status from this message: I queued this with Pavel's ACK after a rebase to current master:
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | twl4030_charger: use devm_request_threaded_irqdrivers/ | +6 | 1 reply | |
| 2/14 | twl4030_charger: use devres for power_supply_register and kzalloc.drivers/ | +9 | 2 replies | |
| 3/14 | twl4030_charger: use runtime_pm to keep usb phy active while charging.drivers/ drivers/ | +9 | 0 replies | |
| 4/14 | twl4030_charger: trust phy to determine when USB power is available.drivers/ | +6 | 0 replies | |
| 5/14 | twl4030_charger: split uA calculation into a function.drivers/ | +35 | 0 replies | |
| 6/14 | twl4030_charger: allow fine control of charger current.drivers/ | +160 | 0 replies | |
| 7/14 | twl4030_charger: distinguish between USB current and 'AC' currentdrivers/ | +29 | 0 replies | |
| 8/14 | twl4030_charger: allow max_current to be managed via sysfs.Documentation/ drivers/ | +87 | 2 replies | |
| 9/14 | twl4030_charger: only draw USB current as negotiated with host.drivers/ | +5 | 0 replies | |
| 10/14 | twl4030_charger: enable manual enable/disable of usb charging.Documentation/ drivers/ | +70 | 0 replies | |
| 11/14 | twl4030_charger: add software controlled linear charging mode.Documentation/ drivers/ | +59 | 0 replies | |
| 12/14 | twl4030_charger: add ac/mode to match usb/modeDocumentation/ drivers/ | +37 | 0 replies | |
| 13/14 | twl4030_charger: Increase current carefully while watching voltage.drivers/ | +60 | 3 replies | |
| 14/14 | twl4030_charger: assume a 'charger' can supply maximum current.drivers/ | +3 | 0 replies |
Reviews trailers per patch
8 of 14 patches have a Reviewed-by or Acked-by.
| Patch | Pavel Machek | Lee Jones | Andreas Kemnade |
|---|---|---|---|
| 1/14 | |||
| 2/14 | |||
| 3/14 | A-b | ||
| 4/14 | |||
| 5/14 | A-b | ||
| 6/14 | A-b | ||
| 7/14 | A-b | ||
| 8/14 | A-b | ||
| 9/14 | A-b | ||
| 10/14 | A-b | ||
| 11/14 | Orignal-by | ||
| 12/14 | A-b | ||
| 13/14 | |||
| 14/14 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 00/14] Enhance twl4030_charger functionality. - V2
Hi Sebastian,
here is V2 of my patches to improve the twl4030 charger. They include improved documentation and removal of changes to the CVENAC bit which I didn't properly understand.
One patch needs to make a change in drivers/mfd, and that has been acked by Lee Jones.
Summary from before:
These patches make a number of improvements to twl4030_charger.
Some are just internal cleanups (e.g. use of devres). Others allow better control of charging through both manual and automatic means.
- the maximum current can be configured via sysfs.
- the charger will only draw that current if it can do so without the voltage dropping too much
- a 'continuous' mode is available which ignores voltage and just takes what it can (to be used with caution, but very useful in some circumstances).
- 'ac' and 'usb' power sources can be configured separately.
Thanks,
NeilBrown
---
NeilBrown (14):
twl4030_charger: use devm_request_threaded_irq
twl4030_charger: use devres for power_supply_register and kzalloc.
twl4030_charger: use runtime_pm to keep usb phy active while charging.
twl4030_charger: trust phy to determine when USB power is available.
twl4030_charger: split uA calculation into a function.
twl4030_charger: allow fine control of charger current.
twl4030_charger: distinguish between USB current and 'AC' current
twl4030_charger: allow max_current to be managed via sysfs.
twl4030_charger: only draw USB current as negotiated with host.
twl4030_charger: enable manual enable/disable of usb charging.
twl4030_charger: add software controlled linear charging mode.
twl4030_charger: add ac/mode to match usb/mode
twl4030_charger: Increase current carefully while watching voltage.
twl4030_charger: assume a 'charger' can supply maximum current.
.../ABI/testing/sysfs-class-power-twl4030 | 45 ++ drivers/mfd/twl-core.c | 9 drivers/power/twl4030_charger.c | 573 +++++++++++++++++--- 3 files changed, 536 insertions(+), 91 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-class-power-twl4030
--
Signature