Add DT support for netxbig LEDs
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest5 patches 0 repliesNew
- v54 patches 0 repliesSuperseded
- v4 posting 2/20 of 3 patches 0 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 posting 1/2 | 3 patches | 0 replies | Superseded | |
| v3 | 3 patches | 0 replies | Superseded | |
| v2 | 3 patches | 0 replies | Superseded | |
| v1 | 0 of 3 patches | 0 replies | Superseded |
Changes in v6 from the cover letter
- Add a patch to set led_classdev max_brightness in the leds-netxbig driver.
- Decrement the current child node refcount with of_node_put() when an error happens while iterating with for_each_child_of_node().
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | leds: netxbig: add device tree bindingDocumentation/ Documentation/ drivers/ +2 more | +391 | 0 replies | |
| 2/5 | ARM: Kirkwood: add LED DT entries for netxbig boardsarch/ arch/ | +140 | 0 replies | |
| 3/5 | ARM: mvebu: remove static LED setup for netxbig boardsarch/ arch/ arch/ +2 more | +0 | 0 replies | |
| 4/5 | leds: netxbig: convert to use the devm_ functionsdrivers/ | +28 | 0 replies | |
| 5/5 | leds: netxbig: set led_classdev max_brightnessdrivers/ | +4 | 1 reply | |
| 5/5 | leds: netxbig: set led_classdev max_brightness | +0 | 1 reply | |
| 5/5 | leds: netxbig: set led_classdev max_brightness | +0 | 1 reply | |
| 5/5 | leds: netxbig: set led_classdev max_brightness | +0 | 1 reply |
Reviews trailers per patch
3 of 8 patches have a Reviewed-by or Acked-by.
| Patch | Linus Walleij | Gregory CLEMENT |
|---|---|---|
| 1/5 | A-b | |
| 2/5 | A-b | |
| 3/5 | A-b | |
| 4/5 | ||
| 5/5 | ||
| 5/5 | ||
| 5/5 | ||
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 0/5] Add DT support for netxbig LEDs
Hello,
This patch series adds DT support for the LEDs found on the Kirkwood-based LaCie boards 2Big and 5Big Network v2.
Changes for v2:
- Check timer mode value retrieved from DT.
- In netxbig_leds_get_of_pdata, don't use unsigned long variables to get timer delay values from DT with function of_property_read_u32_index. Instead, use a temporary u32 variable. This allows to silence a static checker warning.
- Make timer property optional in the binding documentation. It is now aligned with the driver code.
Changes for v3:
- Fix pointer usage with the temporary u32 variable while calling of_property_read_u32_index.
Changes for v4:
- In DT binding document netxbig-gpio-ext.txt, detail byte order for registers and latch mechanism for "enable-gpio".
- In leds-netxbig.c, add some error messages.
- In leds-netxbig.c, fix some "sizeof" style issues.
- In leds-netxbig.c, in netxbig_leds_get_of_pdata(), move the of_property_read_string() calls after the error-prone checks.
- Add some Acked-by.
Changes for v5:
- Rename DT property "bright-max" into the more common "max-brightness".
- Make use of the "max-brightness" DT property. Instead of counting the data pins of the GPIO extension bus, use "max-brightness" to get the maximum brightness level.
- Add a patch to convert the leds-netxbig driver to the devm_ functions.
Changes for v6:
- Add a patch to set led_classdev max_brightness in the leds-netxbig driver.
- Decrement the current child node refcount with of_node_put() when an error happens while iterating with for_each_child_of_node().
Thanks,
Simon
Simon Guinot (5):
leds: netxbig: add device tree binding
ARM: Kirkwood: add LED DT entries for netxbig boards
ARM: mvebu: remove static LED setup for netxbig boards
leds: netxbig: convert to use the devm_ functions
leds: netxbig: set led_classdev max_brightness
.../devicetree/bindings/gpio/netxbig-gpio-ext.txt | 22 ++ .../devicetree/bindings/leds/leds-netxbig.txt | 92 ++++++ arch/arm/boot/dts/kirkwood-net5big.dts | 60 ++++ arch/arm/boot/dts/kirkwood-netxbig.dtsi | 80 +++++ arch/arm/mach-mvebu/Kconfig | 7 - arch/arm/mach-mvebu/Makefile | 1 - arch/arm/mach-mvebu/board.h | 21 -- arch/arm/mach-mvebu/kirkwood.c | 4 - arch/arm/mach-mvebu/netxbig.c | 191 ------------ drivers/leds/leds-netxbig.c | 336 ++++++++++++++++----- include/dt-bindings/leds/leds-netxbig.h | 18 ++ .../linux/platform_data/leds-kirkwood-netxbig.h | 1 + 12 files changed, 531 insertions(+), 302 deletions(-) create mode 100644 Documentation/devicetree/bindings/gpio/netxbig-gpio-ext.txt create mode 100644 Documentation/devicetree/bindings/leds/leds-netxbig.txt delete mode 100644 arch/arm/mach-mvebu/board.h delete mode 100644 arch/arm/mach-mvebu/netxbig.c create mode 100644 include/dt-bindings/leds/leds-netxbig.h
Signature · 1 line
2.1.4